UCT/ROCM: make rocm components compile again on master #7941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix a compile error of the rocm components due to the ep_invalidate interface having been moved to the internal_ops structure. Signed-off-by: Edgar <edgar.gabriel@amd.com>
in the class constructor passing NULL instead of a valid internal_ops can lead to a segfault. Use &uct_base_iface_internal_ops to avoid this problem in rocm/ipc and rocm/gdr. Signed-off-by: Edgar <edgar.gabriel@amd.com>
yosefe
approved these changes
Feb 15, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Make the rocm components compile and run on master again
Why ?
The rocm tls were not compiling currently on master
How ?
The reason I have the changes in two separate commits is because I think the second one might be required for the 12.x branch