v1.13.0 update NEWS and AUTHORS #8241

evgeny-leksikov · 2022-05-18T11:16:25Z

What

preparation for new release

How ?

according to https://github.com/openucx/ucx/wiki/Release-process

@shamisp @tonycurtis @yosefe @edgargabriel @brminich @hoopoepg @Artemy-Mellanox @dmitrygx @Akshay-Venkatesh pls take a look

brminich · 2022-05-18T12:12:14Z

NEWS

+## 1.13.0 (May 17, 2022)
+#### Features
+##### Core
+* Added new objects to VFS: ep local and remote address (e5dff69d5), number of total/failed EP creations (b970b7302), ep destroys and failed eps (6bf7f7d2f)


is it a new approach that we specify sha?

No, just to structurize, I can delete them before merge if it's not needed

I think it is better to delete hash values before release

ep->endpoint

brminich · 2022-05-18T12:13:31Z

NEWS

+* Added support of user memh in proto_v1 (58275b3d9)
+* Added support selecting local address, UCP_EP_PARAM_FIELD_LOCAL_SOCK_ADDR (bac14cafb)
+* Added option to limit GPUDirectRDMA size in rndv, UCX_RNDV_MEMTYPE_DIRECT_SIZE (0442bbef6)
+* Added support pre-registered memory in ucx_perftest (8125b882c)


is it really UCP? Probably it corresponds to tools section

brminich · 2022-05-18T12:15:22Z

NEWS

+* Increased port range + make it dependent from agent_id (c6443fc1b)
+* Checked compiler minimum version (b2cfe5025)
+* Set GOCACHE a local directory that is cleared for each job in CI (3a3a55aa7)
+* Disableed module for goperftest (0a559075f)


brminich · 2022-05-18T12:15:55Z

NEWS

+#### JAVA
+* Throw exception if ucp_mem_query failed
+#### GO
+* Disabled go bindings in rpmbuild. (53ce67838)


plz remove . for consistency

shamisp · 2022-05-18T13:56:57Z

AUTHORS

@@ -17,6 +17,8 @@ Devendar Bureddy <devendar@mellanox.com>
 Devesh Sharma <devesh.sharma@broadcom.com>
 Dmitry Gladkov <dmitrygla@mellanox.com>
 Doug Jacobsen <dmjacobsen@lbl.gov>
+Edgar <edgar.gabriel@amd.com>


Edgar -> Edgar Gabrriel

shamisp · 2022-05-18T13:57:53Z

AUTHORS

 Jakir Kham <jakirkham@gmail.com>
 Jason Gunthorpe <jgg@mellanox.com>
 Jeff Daily <jeff.daily@amd.com>
+JKLiang9714 <1023587725@qq.com>


We should have full name somewhere. All contributors should have signed CLA.

shamisp · 2022-05-18T13:58:41Z

NEWS

+## 1.13.0 (May 17, 2022)
+#### Features
+##### Core
+* Added new objects to VFS: ep local and remote address (e5dff69d5), number of total/failed EP creations (b970b7302), ep destroys and failed eps (6bf7f7d2f)


I think it is better to delete hash values before release

shamisp · 2022-05-18T13:59:19Z

NEWS

+## 1.13.0 (May 17, 2022)
+#### Features
+##### Core
+* Added new objects to VFS: ep local and remote address (e5dff69d5), number of total/failed EP creations (b970b7302), ep destroys and failed eps (6bf7f7d2f)


ep->endpoint

shamisp · 2022-05-18T14:00:03Z

NEWS

+* Added support of UCX static libraries (43f6c3944, 15ce31e89, feed230b3, 942e551aa, e672c9560, e4949b8f4, b6825c64e, ea4d096be, dc46ec23b, 2fb94a67e, 574836e74, 2ea0bf33a, 59f9005b7, cc0c2f328, 47374d098)
+* Capitalized lines in CodeStyle documentation (1d6bc74ee)
+* Added profiling for rkey management routines (dddfbcfe6)
+* Enabled relaxed order for AMD CPUs (59c66aa4c)


Enabled by default PCIe relaxed order...

shamisp · 2022-05-18T14:11:55Z

NEWS

+* Fixed query local/remote saddr (844cf1eb3)
+#### GPU (CUDA, ROCM)
+* Fixed a bug in invalidating address range in CUDA_IPC (c6b13e738)
+* Fixed cuda ctx caching and cleanup


shamisp · 2022-05-18T14:12:21Z

NEWS

+* Fixed a bug in invalidating address range in CUDA_IPC (c6b13e738)
+* Fixed cuda ctx caching and cleanup
+* Fixed error handling on cuda memtype cache initialization (119a81b0f)
+* Fixed rocmem initialization (f8fa567b4)


shamisp · 2022-05-18T14:12:28Z

NEWS

+* Fixed cuda ctx caching and cleanup
+* Fixed error handling on cuda memtype cache initialization (119a81b0f)
+* Fixed rocmem initialization (f8fa567b4)
+* Fixed rocm components compilation (d0f4b1a48)


shamisp · 2022-05-18T14:12:47Z

NEWS

+* Fixed potential segfault in rocm iface_ops
+* Fixed IPC tls reachability check (3dccc3043)
+#### KNEM
+* Fixed mem registration cost (ca891ef7d)


shamisp · 2022-05-18T14:13:11Z

NEWS

+#### UCM
+* Fixed potential hang on init (bf66412b4)
+#### UCS
+* Fixed solve name shadow problem in CentOS6.x


Fixed solve ?

edgargabriel · 2022-05-18T22:50:56Z

Are the news of the 1.12.1 release missing from the file?

Beyond this, I think it looks mostly good to me, from the ROCm code there are three issues that have been merged into the 1.13.0 branch today, not sure whether/how to add that:

increase max. number of hsa agents (7baac93)
fix rocm memory type detection (4a876b5)
use rocm remote_agent if available (79ea940)

evgeny-leksikov · 2022-05-18T23:10:34Z

Are the news of the 1.12.1 release missing from the file?

good point, 1.12.x branch has its own NEWS history, seems like it should be backported to here but I'm not sure if everything from 1.12.1 was backported to master/1.13.x, on other hand diff 1.12.0...1.13.0 has all the changes including 1.12.1 backports. @yosefe is there a good way to resolve this?

@edgargabriel Are increase "max. number of hsa agents (7baac93)" and "use rocm remote_agent if available (79ea940)" features or bugfixes?

edgargabriel · 2022-05-18T23:44:15Z

I think the first item (increase number of hsa agents) is a feature, the other two items are bug fixes

shamisp · 2022-05-19T03:53:09Z

Are the news of the 1.12.1 release missing from the file?

good point, 1.12.x branch has its own NEWS history, seems like it should be backported to here but I'm not sure if everything from 1.12.1 was backported to master/1.13.x, on other hand diff 1.12.0...1.13.0 has all the changes including 1.12.1 backports. @yosefe is there a good way to resolve this?

@edgargabriel Are increase "max. number of hsa agents (7baac93)" and "use rocm remote_agent if available (79ea940)" features or bugfixes?

I typically include changes from all previous releases.

NEWS

shamisp · 2022-05-19T16:23:55Z

Can you please bring over 1.12.x changes to the news file as well ?

evgeny-leksikov · 2022-05-19T22:03:29Z

Can you please bring over 1.12.x changes to the news file as well ?

@shamisp 1.12.1 is here, see line 150

shamisp · 2022-05-20T02:11:32Z

Can you please bring over 1.12.x changes to the news file as well ?

@shamisp 1.12.1 is here, see line 150

oh, somehow overlooked it. thanks

evgeny-leksikov · 2022-05-20T12:17:58Z

@yosefe ok to merge?

yosefe · 2022-05-20T15:52:08Z

@edgargabriel @Akshay-Venkatesh @tonycurtis can you pls review?

edgargabriel · 2022-05-20T15:55:01Z

@edgargabriel @Akshay-Venkatesh @tonycurtis can you pls review?

@yosefe I do not have a button to submit a review, but it looks good to me.

tonycurtis · 2022-05-20T15:53:57Z

NEWS

+## 1.13.0 (May 19, 2022)
+#### Features
+##### Core
+* Added new objects to VFS: local and remote address of enpoint, statistics of ucp_ep_create success/failure, failed/destroyed endpoints


enpoint -> endpoint

tonycurtis · 2022-05-20T15:54:17Z

NEWS

+#### Features
+##### Core
+* Added new objects to VFS: local and remote address of enpoint, statistics of ucp_ep_create success/failure, failed/destroyed endpoints
+* Added support of UCX static libraries


tonycurtis · 2022-05-20T15:55:13Z

NEWS

+* Added new objects to VFS: local and remote address of enpoint, statistics of ucp_ep_create success/failure, failed/destroyed endpoints
+* Added support of UCX static libraries
+* Added profiling for rkey management routines
+* Enabled by default PCIe relaxed order for AMD CPUs


Would reword: PCIe ... enabled by default

tonycurtis · 2022-05-20T15:55:43Z

NEWS

+* Added API to pass pre-registered memory handle to UCP operations
+* Added implementation of AM rendezvous protocol
+* Added 2-stage pipeline rendezvous protocol for GPU
+* Added support of fragment mem_type for v1 pipeline proto, disabled by default


tonycurtis · 2022-05-20T15:56:06Z

NEWS

+* Added support of fragment mem_type for v1 pipeline proto, disabled by default
+* Added active message support for proto v2
+* Added UCP memory registration cache
+* Improved adaptive progress - deactivate iface when discard/cleanup p2p lanes


discarding / cleaning up

tonycurtis · 2022-05-20T16:03:28Z

NEWS

+* Fixed configure if can't find go compiler
+* Standalone performance benchmark
+* Increased port range + make it dependent from agent_id
+* Checked compiler minimum version


tonycurtis · 2022-05-20T16:03:48Z

NEWS

+* Standalone performance benchmark
+* Increased port range + make it dependent from agent_id
+* Checked compiler minimum version
+* Set GOCACHE a local directory that is cleared for each job in CI


GOCACHE to a ...

tonycurtis · 2022-05-20T16:04:14Z

NEWS

+* Set GOCACHE a local directory that is cleared for each job in CI
+* Disabled module for goperftest
+* Fixed OOS build
+* Wait for thread to write to the channel


Needs some context

this is minor test change, so removing it

tonycurtis · 2022-05-20T16:04:48Z

NEWS

+* Fixed memtype cache fallback when memory hooks are not installed
+* Fixed parsing header flags of worker address
+* Fixed pipeline protocol when sending from host memory to GPU memory
+* Fixed transport progress not deactivated when all its connections are closed


its == transport's ?

tonycurtis · 2022-05-20T16:05:23Z

NEWS

+  lead to runtime errors or data corruption when Cuda memory is used and linked
+  statically with cuda runtime.
+  In order to revert to previous behavior (when the application is linked
+  dynamically with cuda runtime), can set UCX_MEM_CUDA_HOOK_MODE=reloc.


you / the user can set

evgeny-leksikov · 2022-05-25T10:05:19Z

@tonycurtis your comments are addressed, could you please review again?

yosefe · 2022-05-25T19:33:21Z

NEWS

+* Added support for fragment mem_type for v1 pipeline proto, disabled by default
+* Added active message support for proto v2
+* Added UCP memory registration cache
+* Improved adaptive progress - deactivate iface when discarding / cleanup up p2p lanes


cleanup up looks weird

yosefe · 2022-05-25T19:34:24Z

NEWS

+* Fixed EP refcount overflow
+* Fixed EP error handling flow
+* Fixed wire compatibility in address unpacking
+* Fixed ucp_ep_close_nb for failed endpoint when related requests have registered memory which should be invalidated


which->that

evgeny-leksikov · 2022-05-26T07:24:14Z

squashed

hoopoepg previously approved these changes May 18, 2022

View reviewed changes

brminich reviewed May 18, 2022

View reviewed changes

evgeny-leksikov dismissed hoopoepg’s stale review via 11d70ac May 18, 2022 12:35

shamisp requested changes May 18, 2022

View reviewed changes

yosefe reviewed May 19, 2022

View reviewed changes

yosefe previously approved these changes May 19, 2022

View reviewed changes

evgeny-leksikov dismissed yosefe’s stale review via fc49e1e May 19, 2022 22:08

evgeny-leksikov force-pushed the v1.13.0-rc1 branch from f87769e to fc49e1e Compare May 19, 2022 22:08

Akshay-Venkatesh previously approved these changes May 19, 2022

View reviewed changes

shamisp self-requested a review May 20, 2022 02:11

shamisp previously approved these changes May 20, 2022

View reviewed changes

tonycurtis suggested changes May 20, 2022

View reviewed changes

edgargabriel previously approved these changes May 20, 2022

View reviewed changes

evgeny-leksikov dismissed stale reviews from edgargabriel, shamisp, and Akshay-Venkatesh via 2b8000c May 21, 2022 09:26

evgeny-leksikov requested a review from tonycurtis May 23, 2022 10:40

tonycurtis previously approved these changes May 25, 2022

View reviewed changes

AUTHORS: 1.13.0

1f80ef0

evgeny-leksikov dismissed tonycurtis’s stale review via e9bf6b4 May 25, 2022 17:10

evgeny-leksikov force-pushed the v1.13.0-rc1 branch from 0aa792d to e9bf6b4 Compare May 25, 2022 17:10

evgeny-leksikov requested a review from yosefe May 25, 2022 17:58

yosefe reviewed May 25, 2022

View reviewed changes

evgeny-leksikov requested a review from yosefe May 26, 2022 05:05

yosefe previously approved these changes May 26, 2022

View reviewed changes

NEWS: 1.13.0

918a101

evgeny-leksikov dismissed yosefe’s stale review via 918a101 May 26, 2022 07:16

evgeny-leksikov force-pushed the v1.13.0-rc1 branch from da6e246 to 918a101 Compare May 26, 2022 07:16

yosefe approved these changes May 26, 2022

View reviewed changes

yosefe merged commit 75f0c25 into openucx:v1.13.x May 26, 2022

v1.13.0 update NEWS and AUTHORS #8241

v1.13.0 update NEWS and AUTHORS #8241

Conversation

evgeny-leksikov commented May 18, 2022

What

How ?

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

edgargabriel commented May 18, 2022 • edited Loading

evgeny-leksikov commented May 18, 2022

edgargabriel commented May 18, 2022

shamisp commented May 19, 2022

shamisp commented May 19, 2022

evgeny-leksikov commented May 19, 2022 • edited Loading

shamisp commented May 20, 2022

evgeny-leksikov commented May 20, 2022

yosefe commented May 20, 2022

edgargabriel commented May 20, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

evgeny-leksikov commented May 25, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

evgeny-leksikov commented May 26, 2022

edgargabriel commented May 18, 2022 •

edited

Loading

evgeny-leksikov commented May 19, 2022 •

edited

Loading