NEWS: 1.13.0 update for RC2 #8327
Conversation
|
evgeny-leksikov
force-pushed
the
v1.13.x
branch
3 times, most recently
from
a20ccc5
to
a7efbdc
Compare
done |
NEWS
Outdated
| @@ -11,7 +11,7 @@ | |||
| ### Features: | |||
| ### Bugfixes: | |||
|
|
|||
| ## 1.13.0 (May 27, 2022) | |||
| ## 1.13.0 (June 26, 2022) | |||
There was a problem hiding this comment.
1.13.0-rc2
should we then also update extra version in configure.ac?
There was a problem hiding this comment.
yes, let's try this, it would be first time we use it in a release.
There was a problem hiding this comment.
can we change NEWS only to v1.13.0-rc2 ?
release date - July 24
There was a problem hiding this comment.
hmm... then I'm not sure I understand relelase process completely. I don't see 1.12.X-rcY sections in NEWS. If we want to track changes for rc1, rc2 and so on, then I would expect to see 1.13.0-rc1, 1.13.0-rc2, ... and then 1.13.0 stable release.
If we squash all release candidates into single section when dropping stable release it requires more efforst because rc2 change log may be not relevant in the end since it's related only for new functionality
There was a problem hiding this comment.
we don't have it in the NEWS now, because it was replaced it to v1.12.0 (for example) before the GA
There was a problem hiding this comment.
then why need to track it before GA if it will be replaced in the end? IMHO it's simpler to merge it every RC. As you can see relevant change log is much shorter.
There was a problem hiding this comment.
this is how it was done so far, so the diff reflects the changes vs. the previous GA.
@shamisp WDYT?
There was a problem hiding this comment.
We do this to track in case somebody picks up one of the RC instead of releases - this way it is actually reflected in news.
There was a problem hiding this comment.
OK, added section on Wiki page https://github.com/openucx/ucx/wiki/Release-process#release-candidates
NEWS
Outdated
| @@ -11,7 +11,7 @@ | |||
| ### Features: | |||
| ### Bugfixes: | |||
|
|
|||
| ## 1.13.0 (May 27, 2022) | |||
| ## 1.13.0.rc2 (June 26, 2022) | |||
configure.ac
Outdated
| define([ucx_ver_major], 1) # Major version. Usually does not change. | ||
| define([ucx_ver_minor], 13) # Minor version. Increased for each release. | ||
| define([ucx_ver_patch], 0) # Patch version. Increased for a bugfix release. | ||
| define([ucx_ver_extra], .rc2) # Extra version string. Empty for a general release. |
There was a problem hiding this comment.
It does not work for RPM build on some systems:
The version Tag
The version tag defines the version of the software being packaged. The version specified should be as close as possible to the format of the original software's version. In most cases, there should be no problem specifying the version just as the software's original developer did. However, there is a restriction. There can be no dashes in the version. If you forget, RPM will remind you:
# rpmbuild -ba cdplayer-1.0.spec
* Package: cdplayer
Illegal '-' char in version: 1.0-a
http://rpm5.org/docs/max-rpm.html
this is why we decided to use . for int4
There was a problem hiding this comment.
What about deb and other package managers ?
|
@shamisp @edgargabriel pls approve as well |
evgeny-leksikov
dismissed stale reviews from edgargabriel and yosefe
via
1b270bf
evgeny-leksikov
force-pushed
the
v1.13.x
branch
2 times, most recently
from
1b270bf
to
fff2793
Compare
NEWS
Outdated
| @@ -11,6 +11,15 @@ | |||
| ### Features: | |||
| ### Bugfixes: | |||
|
|
|||
| ## 1.13.0-rc2 (July 24) | |||
There was a problem hiding this comment.
since it's 1.13 release need to update the 1.13.0 entry and set date to today
There was a problem hiding this comment.
then maybe update 1.13.0 entry to 1.13.0-rc1 and add new one 1.13.0-rc2 (today)?
What
Update NEWS file for RC2
Why ?
Full list of changes since RC1: