AZP/RELEASE: Fixes for v1.14 release #8823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexey-Rivkin
force-pushed
the
topic/fix_v1.14_release
branch
from
6ba2dee
to
99f1884
Compare
artemry-nv
previously approved these changes
Jan 18, 2023
|
Have you verified test release on your fork with these changes? |
For the most part: |
brminich
previously approved these changes
Jan 18, 2023
|
@Al3xR01 the build failure seems relevant, ucx/buildlib/azure-pipelines-release.yml Line 42 in 88d4bb9 it will trigger release pipeline for this PR so we can see if it works |
Alexey-Rivkin
dismissed stale reviews from brminich and artemry-nv
via
56574b2
Alexey-Rivkin
force-pushed
the
topic/fix_v1.14_release
branch
2 times, most recently
from
56574b2
to
34f63d4
Compare
brminich
reviewed
Jan 19, 2023
debian/rules.in
Outdated
| @@ -16,7 +16,7 @@ CUDA_OPT = $(shell echo ${DEB_BUILD_PROFILES} | grep -qw cuda \ | |||
| dh $@ | |||
|
|
|||
| override_dh_auto_configure: | |||
| ./contrib/configure-release-mt --prefix=/usr \ | |||
| ../contrib/configure-release-mt --prefix=/usr \ | |||
There was a problem hiding this comment.
some tests fail because of this change
There was a problem hiding this comment.
Resolved by the sed hack for now.
yosefe
changed the title
Alexey-Rivkin
force-pushed
the
topic/fix_v1.14_release
branch
5 times, most recently
from
6e88186
to
94330e2
Compare
Alexey-Rivkin
force-pushed
the
topic/fix_v1.14_release
branch
from
94330e2
to
301bed3
Compare
|
@yosefe, can you please review? |
brminich
approved these changes
Jan 24, 2023
yosefe
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Manually cherry-pick fixes to resolve various CI failures.