AZP/RELEASE: Add CUDA support to Deb packages #8862
Conversation
debian/rules.in
Outdated
| @@ -9,7 +9,7 @@ | |||
| # Uncomment this to turn on verbose mode. | |||
| #export DH_VERBOSE=1 | |||
|
|
|||
| CUDA_OPT = $(shell echo ${DEB_BUILD_PROFILES} | grep -qw cuda \ | |||
| CUDA_OPT = $(shell echo ${PATH} | grep -qw cuda \ | |||
There was a problem hiding this comment.
why checking PATH var?
maybe check if /usr/local/cuda exists?
There was a problem hiding this comment.
How about the CUDA_VERSION env var?
We can check if the version is new enough.
|
No, simply checking /usr/local/cuda is not good enough. It may contain a version that is not new enough. We currently need version >= 11.6 . And we'll probably switch to 12.0 on most systems soon (in 23.04). This is not logic to keep in the deb package. |
debian/rules.in
Outdated
| @@ -9,7 +9,7 @@ | |||
| # Uncomment this to turn on verbose mode. | |||
| #export DH_VERBOSE=1 | |||
|
|
|||
| CUDA_OPT = $(shell echo ${DEB_BUILD_PROFILES} | grep -qw cuda \ | |||
| CUDA_OPT = $(shell echo ${PATH} | grep -qw cuda \ | |||
There was a problem hiding this comment.
Maybe to check nvcc presence command -v nvcc and its version nvcc --version?
There was a problem hiding this comment.
@tzafrir-mellanox would this work for you?
|
According to @tzafrir-mellanox the fix should be to add -Pcuda to dpkg-buildpackage command, so cuda will be added to DEB_BUILD_PROFILES env var. |
Alexey-Rivkin
force-pushed
the
topic/cuda_support_check
branch
from
584b069
to
3ddbfe9
Compare
|
@Al3xR01 the commit title should contain "AZP/RELEASE: " to trigger release CI |
Alexey-Rivkin
force-pushed
the
topic/cuda_support_check
branch
from
3ddbfe9
to
44017ee
Compare
Alexey-Rivkin
changed the title
Alexey-Rivkin
changed the title
What
Check for CUDA support based on PATH environment variable.
Why ?
Following #8502, UCX release was built without CUDA support.