Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AZP/RELEASE: rm cuda-compat & separate gdrcopy" #8907

Merged
merged 1 commit into from
Mar 1, 2023
Merged

AZP/RELEASE: rm cuda-compat & separate gdrcopy" #8907

merged 1 commit into from
Mar 1, 2023

Conversation

Alexey-Rivkin
Copy link
Collaborator

@Alexey-Rivkin Alexey-Rivkin commented Feb 26, 2023 •
edited
Loading

What

  1. Remove 'cuda-compat' from nvidia/cuda images.
  2. Install 'libnvidia-compute' with driver version matching the CUDA runtime version (e.g. driver ver 515 for CUDA 11.7).
  3. Drop libnvidia-ml.so linking hack, as it is provided by 'libnvidia-compute'.
  4. Uncouple the gdrcopy build profile from cuda profile.
  5. Push images script: exclude commented-out images.
  6. Drop the unsupported Ubuntu16 release.
  7. Drop superfluous dependencies from ucx-cuda DEB, as those are satisfied by default CUDA installation.

Why

Fix dependencies for CUDA build.
Improve the image-building process.

Note: this solution replaces #8900

@Alexey-Rivkin Alexey-Rivkin changed the base branch from master to v1.14.x February 26, 2023 09:39
@Alexey-Rivkin Alexey-Rivkin changed the title Topic/rm deps from debs v14x AZP/RELEASE: rm cuda-compat & separate gdrcopy" Feb 26, 2023
@Alexey-Rivkin Alexey-Rivkin marked this pull request as draft February 26, 2023 09:40
@Alexey-Rivkin Alexey-Rivkin mentioned this pull request Feb 26, 2023
Closed
@Alexey-Rivkin Alexey-Rivkin force-pushed the topic/rm_deps_from_debs-v14x branch 16 times, most recently from cd8182b to 7652e7f Compare February 27, 2023 15:57
@Alexey-Rivkin Alexey-Rivkin marked this pull request as ready for review February 27, 2023 16:05
brminich
brminich previously approved these changes Feb 27, 2023
View reviewed changes
@brminich brminich requested a review from yosefe February 27, 2023 16:19
yosefe
yosefe previously approved these changes Feb 27, 2023
View reviewed changes
@Alexey-Rivkin Alexey-Rivkin marked this pull request as draft February 27, 2023 17:01
artemry-nv
artemry-nv previously requested changes Feb 27, 2023
View reviewed changes
buildlib/dockers/docker-compose.yml Show resolved Hide resolved
buildlib/dockers/ubuntu-release.Dockerfile Show resolved Hide resolved
@Alexey-Rivkin Alexey-Rivkin dismissed stale reviews from yosefe and brminich via c66fa3c February 28, 2023 08:17
@Alexey-Rivkin Alexey-Rivkin force-pushed the topic/rm_deps_from_debs-v14x branch 2 times, most recently from b269fc9 to b10e3ba Compare February 28, 2023 09:02
@Alexey-Rivkin Alexey-Rivkin marked this pull request as ready for review February 28, 2023 09:12
artemry-nv
artemry-nv reviewed Feb 28, 2023
View reviewed changes
buildlib/az-distro-release.yml Show resolved Hide resolved
buildlib/az-distro-release.yml Show resolved Hide resolved
buildlib/az-distro-release.yml Show resolved Hide resolved
buildlib/dockers/ubuntu-release.Dockerfile Outdated Show resolved Hide resolved
buildlib/dockers/ubuntu-release.Dockerfile Show resolved Hide resolved
buildlib/dockers/ubuntu-release.Dockerfile Show resolved Hide resolved
buildlib/dockers/ubuntu-release.Dockerfile Outdated Show resolved Hide resolved
@Alexey-Rivkin Alexey-Rivkin force-pushed the topic/rm_deps_from_debs-v14x branch 3 times, most recently from c3f1616 to d2298c6 Compare February 28, 2023 10:00
artemry-nv
artemry-nv approved these changes Feb 28, 2023
View reviewed changes
buildlib/az-distro-release.yml Show resolved Hide resolved
buildlib/dockers/ubuntu-release.Dockerfile Show resolved Hide resolved
buildlib/dockers/ubuntu-release.Dockerfile Show resolved Hide resolved
brminich
brminich approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@brminich brminich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yosefe, pls take a look

yosefe
yosefe reviewed Feb 28, 2023
View reviewed changes
Copy link
Contributor

@yosefe yosefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but seems some comments from @artemry-nv are still unresolved

@artemry-nv
Copy link
Contributor

artemry-nv commented Feb 28, 2023 •
edited
Loading

LGTM but seems some comments from @artemry-nv are still unresolved

There're some minor remarks (put comments, etc.) remaining - taking into account urgency agreed Alexey will address them separately (not to wait CI and proceed with releasing).

@yosefe yosefe merged commit efde10f into openucx:v1.14.x Mar 1, 2023
@Alexey-Rivkin Alexey-Rivkin mentioned this pull request Mar 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yosefe yosefe yosefe left review comments

@artemry-nv artemry-nv artemry-nv approved these changes

@brminich brminich brminich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alexey-Rivkin @artemry-nv @yosefe @brminich