Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.14.1/NEWS #9075

Merged
merged 1 commit into from
May 16, 2023
Merged

V1.14.1/NEWS #9075

merged 1 commit into from
May 16, 2023

Conversation

shamisp
Copy link
Contributor

@shamisp shamisp commented May 16, 2023

Updating news for v1.14.1 release

@shamisp shamisp changed the base branch from master to v1.14.x May 16, 2023 00:56
@shamisp shamisp requested a review from yosefe May 16, 2023 00:59
@shamisp
Copy link
Contributor Author

shamisp commented May 16, 2023

@pentschev please take a look.

@shamisp shamisp changed the title V1.14.1/news V1.14.1/NEWS May 16, 2023
Copy link
Contributor

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shamisp , I left one comment related to the version, but the changelog look right to me.

@@ -11,6 +11,20 @@
### Features:
### Bugfixes:

## 1.14.1 RC1 (May 17, 2023)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## 1.14.1 RC1 (May 17, 2023)
## 1.14.1 (May 17, 2023)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not meant to be an RC, or is it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is RC1
when 1.14.1 is released we remove this

Copy link
Contributor

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shamisp , I left one comment related to the version, but the changelog look right to me.

Copy link
Contributor

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shamisp , I left one comment related to the version, but the changelog look right to me.

NEWS Outdated Show resolved Hide resolved
NEWS Outdated Show resolved Hide resolved
NEWS Outdated Show resolved Hide resolved
NEWS Outdated Show resolved Hide resolved
NEWS Outdated Show resolved Hide resolved
@shamisp
Copy link
Contributor Author

shamisp commented May 16, 2023

@yosefe fixed - good to go ?

Copy link
Contributor

@yosefe yosefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls squash

@shamisp shamisp merged commit 66f77de into openucx:v1.14.x May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants