Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEWS: Updated NEWS for 1.15.0-rc1 and 1.15.0-rc2. #9244

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

rakhmets
Copy link
Collaborator

@rakhmets rakhmets commented Jul 26, 2023

What

Updated NEWS file filling 1.15.0-rc1 and 1.15.0-rc2. sections.
Added 1.14.1 section.

Copy link
Contributor

@brminich brminich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we also need to port NEWS for v1.14.1 here

NEWS Outdated
Comment on lines 17 to 20

#### RDMA CORE (IB, ROCE, etc.)
* Implemented is_reachable_v2 for IB interfaces

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe no need for extra new lines (to be consistent with prev releases)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

NEWS Outdated
Comment on lines 39 to 41
#### Tests
* Temporary disabled job failures on io_demo counter
* Fixed unit test failures
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe no need for this as it is interlnals

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

NEWS Outdated
* Added user-side memcpy option for AM benchmarks in ucx_perftest

#### Build
* Added UCX LUA dissectors for 64-bit little-endian
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's probably more tool than build section. Also i'd rephrase like
Add wireshark LUA dissectors for some UCX protocols

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

NEWS Outdated
Comment on lines 159 to 163
* Disabled gtests on wireless interfaces
* Disabled JAVA tests on docker interfaces
* Fixed wrong usage of ep_close in examples
* Fixed failures on tests built in single-treaded mode
* Multiple fixes in unit tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe mention just Fixed wrong usage of ep_close in examples, as all the rest seems to be infra internals

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@rakhmets
Copy link
Collaborator Author

i think we also need to port NEWS for v1.14.1 here

Wouldn't that be ambiguous? It can be interpreted as all the listed changes are included to the release...

@rakhmets
Copy link
Collaborator Author

i think we also need to port NEWS for v1.14.1 here

Wouldn't that be ambiguous? It can be interpreted as all the listed changes are included to the release...

It seems that everything is included. I will add NEWS for v1.14.1, and remove duplications.

@rakhmets rakhmets requested a review from brminich July 26, 2023 13:44
@brminich
Copy link
Contributor

I meant add a separate section for v1.14.1, which is missing now (was not merged to this branch when 1.14.1 was created)

NEWS Outdated
* Changed 'unsupported option' ICC command line warning to error
* Removed never used fault-injection configuration option
* Fixed obsolete macro warnings in new autoconf/libtool
* Fixed building UCX with non-old GCC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe with modern GCC versions?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just specify the version that we tested with ? I don't think modern tells me anything

NEWS Outdated
* Added wireshark LUA dissectors for some UCX protocols
#### Build
* Added a separate xpmem deb subpackage
* Added ARM-based artifacts.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the . in the end (for consistency)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

NEWS Outdated

### Bugfixes:
#### UCP
* Reverted the change in lanes selection to fix broken wire compatibility
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

up to version ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "fix wire compatibility with version x.y.z"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was broken in 1.15.0-rc1.

NEWS Outdated
* Reverted the change in lanes selection to fix broken wire compatibility
* Fixed endpoint reconfiguration error due to wrong endpoint configuration locality assignment
#### RDMA CORE (IB, ROCE, etc.)
* Fixed performance degradation when KSM with atomic access fails repeatedly during rkey_pack phase of rendezvous protocol
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too much details. Nobody knows what is KSM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed performance degradation when indirect atomic key is not supported by the hardware

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed details.

Copy link
Contributor

@shamisp shamisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch will conflict with another patch back porting news from 1.14.1

@brminich
Copy link
Contributor

The patch will conflict with another patch back porting news from 1.14.1

No, #9247 is targeting master, while this one updates v1.15.x branch

NEWS Outdated

### Bugfixes:
#### UCP
* Reverted the change in lanes selection to fix broken wire compatibility
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "fix wire compatibility with version x.y.z"?

NEWS Outdated Show resolved Hide resolved
NEWS Outdated Show resolved Hide resolved
NEWS Outdated
* Reverted the change in lanes selection to fix broken wire compatibility
* Fixed endpoint reconfiguration error due to wrong endpoint configuration locality assignment
#### RDMA CORE (IB, ROCE, etc.)
* Fixed performance degradation when KSM with atomic access fails repeatedly during rkey_pack phase of rendezvous protocol
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed performance degradation when indirect atomic key is not supported by the hardware

NEWS Outdated Show resolved Hide resolved
NEWS Outdated Show resolved Hide resolved
NEWS Outdated Show resolved Hide resolved
NEWS Outdated Show resolved Hide resolved
NEWS Outdated Show resolved Hide resolved
NEWS Show resolved Hide resolved
NEWS Outdated

### Bugfixes:
#### UCP
* Reverted the change in lanes selection to fix wire compatibility broken in 1.15.0-rc1
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9244 (comment)
@yosefe the compatibility was broken in rc1, and fixed in rc2. Thus, it shouldn't be mentioned in final news for 1.15.0.
Is the line is ok now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better remove this line IMO

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

yosefe
yosefe previously approved these changes Jul 27, 2023
yosefe
yosefe previously approved these changes Jul 27, 2023
@shamisp
Copy link
Contributor

shamisp commented Jul 27, 2023

Looks good ! Great progress !

@shamisp shamisp self-requested a review July 27, 2023 16:17
@brminich brminich merged commit 4f554ab into openucx:v1.15.x Jul 27, 2023
3 checks passed
@rakhmets rakhmets deleted the topic/news-1.15.0-rc1-rc2 branch October 2, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants