-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEWS: Updated NEWS for 1.15.0-rc1 and 1.15.0-rc2. #9244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we also need to port NEWS for v1.14.1 here
NEWS
Outdated
|
||
#### RDMA CORE (IB, ROCE, etc.) | ||
* Implemented is_reachable_v2 for IB interfaces | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe no need for extra new lines (to be consistent with prev releases)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
NEWS
Outdated
#### Tests | ||
* Temporary disabled job failures on io_demo counter | ||
* Fixed unit test failures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe no need for this as it is interlnals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
NEWS
Outdated
* Added user-side memcpy option for AM benchmarks in ucx_perftest | ||
|
||
#### Build | ||
* Added UCX LUA dissectors for 64-bit little-endian |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's probably more tool than build section. Also i'd rephrase like
Add wireshark LUA dissectors for some UCX protocols
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
NEWS
Outdated
* Disabled gtests on wireless interfaces | ||
* Disabled JAVA tests on docker interfaces | ||
* Fixed wrong usage of ep_close in examples | ||
* Fixed failures on tests built in single-treaded mode | ||
* Multiple fixes in unit tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe mention just Fixed wrong usage of ep_close in examples
, as all the rest seems to be infra internals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
Wouldn't that be ambiguous? It can be interpreted as all the listed changes are included to the release... |
It seems that everything is included. I will add NEWS for v1.14.1, and remove duplications. |
I meant add a separate section for v1.14.1, which is missing now (was not merged to this branch when 1.14.1 was created) |
NEWS
Outdated
* Changed 'unsupported option' ICC command line warning to error | ||
* Removed never used fault-injection configuration option | ||
* Fixed obsolete macro warnings in new autoconf/libtool | ||
* Fixed building UCX with non-old GCC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe with modern GCC versions
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just specify the version that we tested with ? I don't think modern
tells me anything
NEWS
Outdated
* Added wireshark LUA dissectors for some UCX protocols | ||
#### Build | ||
* Added a separate xpmem deb subpackage | ||
* Added ARM-based artifacts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove the .
in the end (for consistency)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
f497d8a
to
ed1f51b
Compare
NEWS
Outdated
|
||
### Bugfixes: | ||
#### UCP | ||
* Reverted the change in lanes selection to fix broken wire compatibility |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
up to version ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe "fix wire compatibility with version x.y.z"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was broken in 1.15.0-rc1.
NEWS
Outdated
* Reverted the change in lanes selection to fix broken wire compatibility | ||
* Fixed endpoint reconfiguration error due to wrong endpoint configuration locality assignment | ||
#### RDMA CORE (IB, ROCE, etc.) | ||
* Fixed performance degradation when KSM with atomic access fails repeatedly during rkey_pack phase of rendezvous protocol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too much details. Nobody knows what is KSM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed performance degradation when indirect atomic key is not supported by the hardware
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patch will conflict with another patch back porting news from 1.14.1
No, #9247 is targeting master, while this one updates v1.15.x branch |
NEWS
Outdated
|
||
### Bugfixes: | ||
#### UCP | ||
* Reverted the change in lanes selection to fix broken wire compatibility |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe "fix wire compatibility with version x.y.z"?
NEWS
Outdated
* Reverted the change in lanes selection to fix broken wire compatibility | ||
* Fixed endpoint reconfiguration error due to wrong endpoint configuration locality assignment | ||
#### RDMA CORE (IB, ROCE, etc.) | ||
* Fixed performance degradation when KSM with atomic access fails repeatedly during rkey_pack phase of rendezvous protocol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed performance degradation when indirect atomic key is not supported by the hardware
NEWS
Outdated
|
||
### Bugfixes: | ||
#### UCP | ||
* Reverted the change in lanes selection to fix wire compatibility broken in 1.15.0-rc1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#9244 (comment)
@yosefe the compatibility was broken in rc1, and fixed in rc2. Thus, it shouldn't be mentioned in final news for 1.15.0.
Is the line is ok now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better remove this line IMO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
2042647
to
9d6d6f1
Compare
Looks good ! Great progress ! |
Added 1.14.1 section.
6bf5eab
to
7babd13
Compare
What
Updated
NEWS
file filling 1.15.0-rc1 and 1.15.0-rc2. sections.Added 1.14.1 section.