AZP/RELEASE: Fix launch condition-v1.15.x #9329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosefe
reviewed
Aug 30, 2023
buildlib/az-helpers.sh
Outdated
| @@ -139,6 +140,16 @@ function az_module_unload() { | |||
| module unload "${module}" || true | |||
| } | |||
|
|
|||
| # Ensure that GPU is present | |||
| check_gpu() { | |||
There was a problem hiding this comment.
how come we back port only function definition and not back-porting any usage of this function?
either it's already defined, or not needed
There was a problem hiding this comment.
I stand corrected.
It's better to not add the GPU check in this PR.
Alexey-Rivkin
force-pushed
the
topic/release_launch-v1.15.x
branch
from
5ea2de6
to
efdf63b
Compare
yosefe
previously approved these changes
Aug 30, 2023
Alexey-Rivkin
force-pushed
the
topic/release_launch-v1.15.x
branch
from
e354834
to
b4355b4
Compare
|
squashed |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s), but failed to run 1 pipeline(s). |
|
io_demo tests fail, as this PR doesn't include the io_demo setters fix #9332 |
artemry-nv
previously approved these changes
Sep 1, 2023
Alexey-Rivkin
dismissed stale reviews from artemry-nv and yosefe
via
65d4329
Alexey-Rivkin
force-pushed
the
topic/release_launch-v1.15.x
branch
2 times, most recently
from
5f16f78
to
5109d90
Compare
auto-merge was automatically disabled
September 4, 2023 05:05
Pull request was converted to draft
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s), but failed to run 1 pipeline(s). |
Alexey-Rivkin
force-pushed
the
topic/release_launch-v1.15.x
branch
from
5109d90
to
262dff3
Compare
yosefe
approved these changes
Sep 11, 2023
artemry-nv
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #9327.