Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UCP/RNDV: Do not use recv ppln with generic send buf - v1.15.x #9374

Merged
merged 1 commit into from
Sep 19, 2023
Merged

UCP/RNDV: Do not use recv ppln with generic send buf - v1.15.x #9374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/ucp/rndv/rndv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,15 +122,15 @@ ucp_rndv_is_put_pipeline_needed(uintptr_t remote_address, size_t length,
const ucp_ep_rndv_zcopy_config_t *put_zcopy,
int is_get_zcopy_failed)
{
if ((remote_address != 0) &&
if ((remote_address == 0) ||
yosefe marked this conversation as resolved.
Show resolved Hide resolved
(ucp_rkey_packed_mem_type(rkey_buf) == UCS_MEMORY_TYPE_HOST)) {
return 0;
}

/* Fallback to PUT pipeline if: */
return /* Remote mem type is non-HOST memory OR can't do GET ZCOPY */
((remote_address == 0) || (get_zcopy->max == 0) ||
(length < get_zcopy->min) || is_get_zcopy_failed) &&
((get_zcopy->max == 0) || (length < get_zcopy->min) ||
is_get_zcopy_failed) &&
/* AND can do PUT assuming that configurations are symmetric */
((put_zcopy->max != 0) && (length >= put_zcopy->min));
}
Expand Down
Loading