UCS/RCACHE: Add support for dynamic region alignment #9441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosefe
reviewed
Oct 26, 2023
Artemy-Mellanox
force-pushed
the
topic/rcache_align
branch
3 times, most recently
from
878e7fd
to
8b93a57
Compare
yosefe
reviewed
Oct 30, 2023
src/ucs/memory/rcache.c
Outdated
| ucs_list_head_init(®ion_list); | ||
| ucs_rcache_find_regions(rcache, *start, old_start, ®ion_list); | ||
| ucs_rcache_find_regions(rcache, *start, old_start - 1, ®ion_list); |
There was a problem hiding this comment.
ucs_rcache_find_regions() expects an inclusive end, see other uses.
There was a problem hiding this comment.
can we write the code as while loop that stops when the list of overlapping regions is empty?
There was a problem hiding this comment.
we always can replace goto with do {...} while(!list_empty)
do we want to avoid traversing regions we already cleaned as we do here?
yosefe
reviewed
Nov 1, 2023
src/ucs/memory/rcache.c
Outdated
| ucs_list_head_init(®ion_list); | ||
| ucs_rcache_find_regions(rcache, *start, old_start, ®ion_list); | ||
| ucs_rcache_find_regions(rcache, *start, old_start - 1, ®ion_list); |
There was a problem hiding this comment.
can we write the code as while loop that stops when the list of overlapping regions is empty?
Artemy-Mellanox
force-pushed
the
topic/rcache_align
branch
from
91f02d2
to
56edd94
Compare
yosefe
reviewed
Nov 6, 2023
| @@ -402,7 +402,7 @@ UCS_MT_TEST_F(test_rcache, merge, 6) { | |||
| munmap(mem, size1 + pad + size2); | |||
| } | |||
|
|
|||
| UCS_MT_TEST_F(test_rcache, merge_aligned, 6) | |||
| UCS_TEST_F(test_rcache, merge_aligned) | |||
yosefe
approved these changes
Nov 7, 2023
Artemy-Mellanox
force-pushed
the
topic/rcache_align
branch
from
40f7d42
to
85d2d9d
Compare
This was referenced May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why ?
Some transports (e.g. gdrcopy) require special alignment.
How ?
Regions in the UCP rcache will select the maximum alignment from the MD registrations they comprise. When merging regions, the rcache will also choose the maximum alignment.