UCP/WIREUP: Consider local distance during slow lanes dropping #9512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pentschev
reviewed
Nov 29, 2023
There was a problem hiding this comment.
I can confirm this resolves the issue I was experiencing on my end. Thanks @ivankochin !
brminich
reviewed
Nov 29, 2023
| bw_local = ucp_tl_iface_bandwidth(worker->context, | ||
| &wiface->attr.bandwidth); | ||
| } else { | ||
| bw_local = ucp_wireup_iface_bw_distance(wiface); |
There was a problem hiding this comment.
pls add a short comment what it fixes
👍 otherwise
yosefe
previously approved these changes
Nov 30, 2023
brminich
approved these changes
Nov 30, 2023
ivankochin
force-pushed
the
ucp/wireup/consider-local-distance-duing-slow-lanes-dropping
branch
from
47542e4
to
350d795
Compare
This was referenced Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Make lanes filtering function aware of local distance.
Why ?
Remote BW value already capped by distance during the comparison, but local BW doesn't consider distance. That can cause reconfiguration errors because the peers can calculate different BW numbers for the same lane.