UCT/IB: Add FLID based routing support - v1.16.x #9557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosefe
changed the title
iyastreb
reviewed
Dec 20, 2023
src/uct/ib/base/ib_iface.c
Outdated
| return ntohs(*((uint16_t*)UCS_PTR_BYTE_OFFSET(gid->raw, 4))); | ||
| } | ||
|
|
||
| static int uct_ib_iface_is_flid_enabled(uct_ib_iface_t *iface) |
There was a problem hiding this comment.
can we pass iface by const?
src/uct/ib/base/ib_iface.c
Outdated
| return be64toh(gid->global.subnet_prefix) & 0xffff; | ||
| } | ||
|
|
||
| uint16_t uct_ib_iface_resolve_remote_flid(uct_ib_iface_t *iface, |
iyastreb
approved these changes
Dec 20, 2023
yosefe
force-pushed
the
topic/uct-ib-add-flid-based-routing-support-v1.16.x
branch
from
a45b607
to
460afd4
Compare
yosefe
deleted the
topic/uct-ib-add-flid-based-routing-support-v1.16.x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Backport #9551
Don't port test_jenkins.sh change, and one minor conflict in ib_iface.h