UCT/MM: Replaced error value with debug log message for shm_unlink #9670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosefe
reviewed
Feb 8, 2024
yosefe
reviewed
Feb 8, 2024
|
@shasson5 please squash |
yosefe
reviewed
Feb 14, 2024
src/uct/sm/mm/posix/mm_posix.c
Outdated
| if (status != UCS_OK) { | ||
| goto err_close; | ||
| } | ||
| uct_posix_unlink(md, seg->seg_id, UCS_LOG_LEVEL_DEBUG); |
src/uct/sm/mm/posix/mm_posix.c
Outdated
| @@ -586,7 +584,7 @@ uct_posix_mem_alloc(uct_md_h tl_md, size_t *length_p, void **address_p, | |||
| err_close: | |||
| close(fd); | |||
| if (!(seg->seg_id & UCT_POSIX_SEG_FLAG_PROCFS)) { | |||
| uct_posix_unlink(md, seg->seg_id); | |||
| uct_posix_unlink(md, seg->seg_id, UCS_LOG_LEVEL_ERROR); | |||
yosefe
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Display log message instead of returning an error when failing on
uct_posix_unlinkinuct_posix_mem_allocWhy ?
Prevent UCX init from failing over sporadic "No Such file or directory" error when trying to delete a SHM file.
This PR fix this issue:
https://redmine.mellanox.com/issues/3602767
Also the same error was seen in:
https://redmine.mellanox.com/issues/3730544