Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RELEASE: Update NEWS 1.16 RC5 #9682

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

shasson5
Copy link
Contributor

What

Update NEWS 1.16 RC5

Why ?

To progress release process

@shasson5 shasson5 requested review from shamisp and gleon99 and removed request for shamisp and gleon99 February 11, 2024 18:25
NEWS Outdated Show resolved Hide resolved
NEWS Outdated Show resolved Hide resolved
Copy link
Contributor

@yosefe yosefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems few fixes are missing for example #9653, #9658

NEWS Outdated Show resolved Hide resolved
Copy link
Contributor

@yosefe yosefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NEWS Outdated
Comment on lines 135 to 136
#### AZP
* Fixed CUDA CI issues
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can remove this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, it was copy paste issue #9658 is not relevant

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean remove the line?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove mentioning the fix of CI issues from the news

NEWS Outdated
* Fixed ROCM building and testing
* Fixed ROCm building and testing
#### AZP
* Fixed CUDA CI issues
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix CI failures when GPU is present but disabled (from the PR description..)

Copy link
Contributor Author

@shasson5 shasson5 Feb 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflict with Yossi's comment (to remove this line)

NEWS Outdated
@@ -120,7 +121,8 @@
* Fixed a deadlock when forked debugger is attached during an error in rcache operation
* Fixed crash due to passing null pointer to log function
* Fixed crash due to incorrect hashing method
* Fixed crash in configuration parser cleanup by moving it after profiler cleanup
* Fixed crash in configuration parser cleanup by moving it after profiler cleanup
* Fixed floating point division by zero
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed floating point division by zero during protocols initialization

NEWS Outdated
* Fixed ROCM building and testing
* Fixed ROCm building and testing
* Removed libnvidia-compute version dependency
* Removed libibmad/libumad from default external libraries list
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed libibmad/libumad from default build configuration to avoid runtime dependency

@shasson5 shasson5 requested a review from yosefe February 13, 2024 09:07
Copy link
Contributor

@yosefe yosefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls squash

@shasson5
Copy link
Contributor Author

@yosefe can merge?

@gleon99 gleon99 merged commit 6b209e4 into openucx:v1.16.x Feb 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants