Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMAKE: Add targets once in case of multiple find_package() - v1.16.x #9702

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

tvegas1
Copy link
Contributor

@tvegas1 tvegas1 commented Feb 20, 2024

What

Backport #9696 to support multiple cmake find_package() invocations.

@tvegas1
Copy link
Contributor Author

tvegas1 commented Feb 20, 2024

we'd also need NEWS file update under rc3?

@brminich brminich changed the title CMAKE: Add targets once in case of multiple find_package() CMAKE: Add targets once in case of multiple find_package() - v 1.16.x Feb 20, 2024
@rakhmets
Copy link
Collaborator

we'd also need NEWS file update under rc3?

I've just created a pre-release... But I can remove tag and RC to avoid having two RCs for two single PRs.

@rakhmets
Copy link
Collaborator

we'd also need NEWS file update under rc3?

I've just created a pre-release... But I can remove tag and RC to avoid having two RCs for two single PRs.

Please ignore my suggestion to remove the existing tag.
NEWS should be updated by adding section for RC4.

cc @shasson5

@yosefe yosefe changed the title CMAKE: Add targets once in case of multiple find_package() - v 1.16.x CMAKE: Add targets once in case of multiple find_package() - v1.16.x Feb 20, 2024
@gleon99 gleon99 merged commit 71f1466 into openucx:v1.16.x Feb 21, 2024
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants