UCT/CUDA: Return unreachable from rkey unpack in case of error - v1.16.x #9717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakhmets
previously approved these changes
Feb 28, 2024
tvegas1
previously approved these changes
Feb 28, 2024
brminich
changed the title
brminich
changed the title
|
Do we need the fix in master branch? |
yes, le'ts wait for @yosefe approve |
yosefe
reviewed
Mar 5, 2024
src/uct/cuda/cuda_ipc/cuda_ipc_md.c
Outdated
| UCT_CUDA_IPC_GET_DEVICE(this_device); | ||
| UCT_CUDA_IPC_DEVICE_GET_COUNT(num_devices); | ||
| if ((CUDA_SUCCESS != cuCtxGetDevice(&this_device)) || | ||
| (CUDA_SUCCESS != cuDeviceGetCount(&num_devices))) { |
There was a problem hiding this comment.
I think we can keep the error message if num_devices query fails, since it should not happen at this point
brminich
force-pushed
the
uct/cuda_ipc_fix_rkey_unpack
branch
from
03e8955
to
11511cb
Compare
rakhmets
reviewed
Mar 6, 2024
brminich
force-pushed
the
uct/cuda_ipc_fix_rkey_unpack
branch
from
11511cb
to
9cdac44
Compare
rakhmets
approved these changes
Mar 6, 2024
tvegas1
approved these changes
Mar 6, 2024
yosefe
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Always return unreachable from
uct_cuda_ipc_rkey_unpackto ignore cuda IPC key when it can't be used (e.g. cuda device is not set for this process)