UCT/IB/MD: Disable MR multithreading registration - м1.16.x #9779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosefe
reviewed
Mar 26, 2024
src/uct/ib/base/ib_md.c
Outdated
Comment on lines
141
to
143
| "registering thread is bound to by hard affinity.\n" | ||
| "MT registration disabled by default in that UCX version due to " | ||
| "imlementation issues.", |
|
Customer confirmed that this patch doesn't harm the performance on his side. |
tvegas1
approved these changes
Mar 26, 2024
ivankochin
changed the title
yosefe
approved these changes
Mar 27, 2024
|
@ivankochin pls squash |
ivankochin
force-pushed
the
uct/ib/disable-mr-mt-registration-1.16
branch
from
f998684
to
2c10547
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Disabling MR MT registration.
Why
The implementation of multithreading MR registration contains many errors that are already fixed in master.