Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Temporarily disable Direct IO by default" #16629

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Re-enable direct IO by default now that the #16598 has been resolved.

Description

This reverts commit 4121059 now that b4e4cbe has been merged.

How Has This Been Tested?

This functional has been manually tested in #16598 and by all previous CI runs since it was integrated.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

This reverts commit 4121059 now
that b4e4cbe has been merged.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Oct 9, 2024
@amotin
Copy link
Member

amotin commented Oct 10, 2024

There is still unresolved issue with potentially insufficient range locking in zfs_getpages() on FreeBSD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Code Review Needed Ready for review and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants