-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Little beautification of image cache mgmt code #2063
Conversation
@audiodude This PR has two objectives:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@audiodude There is no way tomdo better for the second bukket point? |
@audiodude Do you in particular could explain to me please what does this line? Does it copy only the headers or does it copy the body as well? |
I believe it copies everything but the body.
So it's creating an anonymous function that takes an object, and destructures it into two parts, |
Just wondering, do you want me to correct all the little grammatical mistakes in the comments? |
You can obviously. Anything to improve code base is always welcome. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2063 +/- ##
==========================================
- Coverage 74.44% 74.36% -0.08%
==========================================
Files 41 41
Lines 3146 3144 -2
Branches 689 688 -1
==========================================
- Hits 2342 2338 -4
- Misses 684 685 +1
- Partials 120 121 +1 ☔ View full report in Codecov by Sentry. |
474603a
to
6dd1c5c
Compare
6dd1c5c
to
d339e53
Compare
This is mostly clarification and documentation around the image (cache) mgmt.