fix: respect the allParamsOptional config option in React query initi… #1583
+23
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will let @anymaniax review but I feel like there is a more clever way to do this. It's so similar to the other branch of code? |
anymaniax
reviewed
Aug 22, 2024
| @@ -26,6 +26,7 @@ export const getProps = ({ | |||
| const bodyProp = { | |||
| name: body.implementation, | |||
| definition: `${body.implementation}${body.isOptional ? '?' : ''}: ${body.definition}`, | |||
| definedDefinition: `${body.implementation}: ${body.isOptional ? 'undefined' : ''} | ${body.definition}`, | |||
There was a problem hiding this comment.
would be better not modifying the core for that. You could do the same think directly in the react query client no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Fixes #1564
Related PRs
List related PRs against other branches:
Todos
Steps to Test or Reproduce
Follow the steps mentioned #1564