Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ubi wsl #3473

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Ubi wsl #3473

merged 1 commit into from
Jul 25, 2023

Conversation

croissanne
Copy link
Member

@croissanne croissanne commented Jun 1, 2023 •
edited
Loading

Adds a wsl image type based on the UBI package set.

The UBI package set isn't entirely identical to the current ubi images (2 or 3 packages differ), mostly because we don't include CRB.

@croissanne croissanne force-pushed the ubi-wsl branch 4 times, most recently from 6e1d183 to aed4ed5 Compare June 5, 2023 10:20
@croissanne croissanne force-pushed the ubi-wsl branch 20 times, most recently from 6687fb1 to 890c44a Compare July 5, 2023 08:28
@achilleas-k achilleas-k mentioned this pull request Jul 10, 2023
Open
14 tasks
@croissanne croissanne mentioned this pull request Jul 10, 2023
Merged
@croissanne croissanne force-pushed the ubi-wsl branch 4 times, most recently from 040d63b to 73f623c Compare July 12, 2023 10:23
@achilleas-k achilleas-k reopened this Jul 13, 2023
@achilleas-k
Copy link
Member

Oops, I didn't notice this was updated properly. Sorry!

@croissanne croissanne marked this pull request as ready for review July 19, 2023 11:27
schutzbot
schutzbot reviewed Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@schutzbot schutzbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD dba1292 with the main merge-base cb07341). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/4690045427/artifacts/browse

@croissanne
Copy link
Member Author

wait @achilleas-k should I add the test case to osbuild/images rather than composer?

@achilleas-k
Copy link
Member

wait @achilleas-k should I add the test case to osbuild/images rather than composer?

Testing in images would be tricky now because we can't build rpms without composer. Let's keep adding integration (and boot) tests here for now until I have boot testing set up in images.

schutzbot
schutzbot reviewed Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@schutzbot schutzbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD de1608a with the main merge-base cb07341). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/4700299054/artifacts/browse

@henrywang
Copy link
Member

henrywang commented Jul 21, 2023 •
edited
Loading

  1. Tests / edge-ami-9 and Tests / edge-ami-cs9 need a rebase because PR Include test for edge-ami image type #3542 just got merged yesterday.

  2. Tests / edge-minimal-raw-8, Tests / edge-minimal-raw-9, Tests / edge-minimal-raw-cs8 and Tests / edge-minimal-raw-cs9 need PR Update osbuild/images #3565.

@achilleas-k
Copy link
Member

Sanne is out this week so I took care of the rebase.

achilleas-k
achilleas-k approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving after rebase.

schutzbot
schutzbot reviewed Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@schutzbot schutzbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD 2c8b6f5 with the main merge-base cac9327). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/4726344032/artifacts/browse

@achilleas-k achilleas-k merged commit b2451c6 into osbuild:main Jul 25, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schutzbot schutzbot schutzbot left review comments

@achilleas-k achilleas-k achilleas-k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@croissanne @achilleas-k @henrywang @schutzbot