tools: Set a+x on rpm_spec_vendor2provides #3562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Local packages do not have a version number. Fake it with 'HEAD' to indicate it's using whatever the working directory is pointing at. The Provides line will then look like: Provides: bundled(golang(../osbuild-images)) = HEAD which rpmbuild is happy to process into an rpm. This is ONLY for test builds on local systems and should never be seen in the wild.
|
(I just noticed the testing PR you made using a url, so that explains why your tests were working an mine weren't) I've added a patch here that fixes things for me, using a fake version when using filesystem paths in the replace line. |
supakeen
approved these changes
Jul 18, 2023
|
Oh, my bad. Thanks! |
achilleas-k
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New script is missing the executable bit.