Handle panics in the osbuild job & fix panic when OCI authentication fails #3666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't make sense to have them together. Signed-off-by: Ondřej Budai <ondrej@budai.cz>
Previously, the worker would happily report success if osbuild succeeded, there was no JobError, but the job actually panicked in the meantime. Let's fix this by adding a recovery mechanism. Signed-off-by: Ondřej Budai <ondrej@budai.cz>
resp.IsResumable crashes if resp.MultipartUploadResponse == nil. This happens for instance when authentication fails. Fix this by also checking the MultipartUploadResponse field. Signed-off-by: Ondřej Budai <ondrej@budai.cz>
|
|
bcl
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes related to each other:
osbuildactually succeeded and noJobErrorwas set, we currently report success back to composer. That's wrong. I added arecover()to set an error state.