osbuild-worker: rework the workerClientErrorFrom() error
#4254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thozza
reviewed
Jul 11, 2024
mvo5
force-pushed
the
clienterrors-workerClientErrorFrom
branch
from
86f4503
to
36fac07
Compare
mvo5
force-pushed
the
clienterrors-workerClientErrorFrom
branch
from
36fac07
to
43908d5
Compare
mvo5
force-pushed
the
clienterrors-workerClientErrorFrom
branch
2 times, most recently
from
2d97926
to
45003b8
Compare
The workerClientErrorFrom() was returning an `*clienterrors.Error` and an `error` (if something with the conversation goes wrong. But the calling code was expecting that even if an `error` is returned the `*clienterrors.Error` is still valid. The caller would then just log the error. As returning a valid `value` even when there is an `error` is an unexpected pattern this commit changes the code to always return a `*clienterrors.Error` and log any issue via the logger.
mvo5
force-pushed
the
clienterrors-workerClientErrorFrom
branch
from
45003b8
to
96633ff
Compare
Sorry, had to rebase because of conflicts, could you please re-review? |
thozza
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workerClientErrorFrom() was returning an
*clienterrors.Errorand anerror(if something with the conversation goes wrong.But the calling code was expecting that even if an
erroris returned the*clienterrors.Erroris still valid. The caller would then just log the error. As returning a validvalueeven when there is anerroris an unexpected pattern this commit changes the code to always return a*clienterrors.Errorand log any issue via the logger.