Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSCAP json tailoring (HMS-3827) #4272

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

kingsleyzissou
Copy link
Contributor

@kingsleyzissou kingsleyzissou commented Jul 23, 2024

This pull request includes:

  • changes to the blueprints to enable json tailoring
  • update the cloudapi to accept json tailoring options

 

  • adequate testing for the new functionality or fixed issue
  • adequate documentation informing people about the change such as
    • submit a PR for the READMEs listed here
    • submit a PR for the osbuild.org website repository if this PR changed any behavior not covered by the automatically updated READMEs

Depends on: osbuild/images#798

Copy link
Member

@croissanne croissanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but one question about the go.mod changes.

go.mod Outdated Show resolved Hide resolved
@kingsleyzissou kingsleyzissou force-pushed the oscap-json-tailoring branch 2 times, most recently from 75db4cd to 8d07b99 Compare August 6, 2024 14:21
Add an initial test for OpenSCAP tailoring customizations since we will
be expanding the tailoring options to support json tailoring.
Add support to the blueprints for json tailoring files
Add support for json tailoring files in the cloudapi. Expand the tests
to check that the options returned are okay and that tailoring options
and json tailoring options can't be provided at the same time.
Copy link
Member

@croissanne croissanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@croissanne croissanne merged commit 2da3a73 into osbuild:main Aug 7, 2024
43 of 44 checks passed
@kingsleyzissou kingsleyzissou deleted the oscap-json-tailoring branch August 7, 2024 10:29
thozza added a commit to thozza/osbuild-composer that referenced this pull request Aug 7, 2024
This was forgotten in [1], which depens on [2], which landed in osbuild
v120.

[1] osbuild#4272
[2] osbuild/osbuild#1777

Signed-off-by: Tomáš Hozza <thozza@redhat.com>
thozza added a commit to thozza/osbuild-composer that referenced this pull request Aug 12, 2024
This was forgotten in [1], which depens on [2], which landed in osbuild
v120.

[1] osbuild#4272
[2] osbuild/osbuild#1777

Signed-off-by: Tomáš Hozza <thozza@redhat.com>
thozza added a commit to thozza/osbuild-composer that referenced this pull request Aug 12, 2024
This was forgotten in [1], which depens on [2], which landed in osbuild
v120.

[1] osbuild#4272
[2] osbuild/osbuild#1777

Signed-off-by: Tomáš Hozza <thozza@redhat.com>
thozza added a commit to thozza/osbuild-composer that referenced this pull request Aug 12, 2024
This was forgotten in [1], which depens on [2], which landed in osbuild
v120.

[1] osbuild#4272
[2] osbuild/osbuild#1777

Signed-off-by: Tomáš Hozza <thozza@redhat.com>
thozza added a commit that referenced this pull request Aug 13, 2024
This was forgotten in [1], which depens on [2], which landed in osbuild
v120.

[1] #4272
[2] osbuild/osbuild#1777

Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants