Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osbuild-composer: add Requires: osbuild-dnf-json-api = 7 #4308

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

mvo5
Copy link
Contributor

@mvo5 mvo5 commented Aug 15, 2024

Use an exact version dependency on the osbuild-dnf-json-api to ensure incompatible json protocol changes cannot break composer.

See also osbuild/osbuild#1849

@mvo5 mvo5 requested a review from thozza August 15, 2024 14:03
Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvo5 mvo5 marked this pull request as ready for review August 21, 2024 13:44
@thozza thozza enabled auto-merge (rebase) August 22, 2024 15:02
@thozza thozza disabled auto-merge August 22, 2024 15:03
Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an excellent idea :)

Use an exact version dependency on the `osbuild-dnf-json-api` to
ensure incompatible json protocol changes cannot break composer.

See also osbuild/osbuild#1849
@mvo5 mvo5 enabled auto-merge (rebase) August 26, 2024 06:36
@mvo5 mvo5 merged commit 9e5fdc8 into osbuild:main Aug 26, 2024
46 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants