Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHEL-10] Add gce and image-installer image types (COMPOSER-2193) #4314

Merged
merged 8 commits into from
Aug 23, 2024

Conversation

thozza
Copy link
Member

@thozza thozza commented Aug 20, 2024

Update osbuild/images ref, adding support for c10s / el10 gce and image-installer image types. Also enable testing for these.

In addition, remove EOL Fedora repos.

This pull request includes:

  • adequate testing for the new functionality or fixed issue
  • adequate documentation informing people about the change such as
    • submit a PR for the READMEs listed here
    • submit a PR for the osbuild.org website repository if this PR changed any behavior not covered by the automatically updated READMEs

@thozza thozza added the WIP+test Work in progress but run Gitlab CI. label Aug 20, 2024
@thozza thozza marked this pull request as draft August 20, 2024 15:09
@thozza thozza force-pushed the COMPOSER-2193 branch 6 times, most recently from 25a81ef to 6055c80 Compare August 21, 2024 12:48
Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preliminary LGTM! :)

Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Enable testing of GCE image type on el10 / c10s. The el10 / c10s image
type temporarily uses cloud-init, because there are no GCP guest tools
for el10 / c10s yet and el9 version can't be installed. This implies
that we need to set the SSH key in the instance metadata and use SSH
directly.

Signed-off-by: Tomáš Hozza <thozza@redhat.com>
@thozza thozza changed the title Test https://github.com/osbuild/images/pull/869 [RHEL-10] Add gce and image-installer image types (COMPOSER-2193) Aug 22, 2024
@thozza thozza marked this pull request as ready for review August 22, 2024 09:21
@thozza thozza removed the WIP+test Work in progress but run Gitlab CI. label Aug 22, 2024
achilleas-k
achilleas-k previously approved these changes Aug 22, 2024
@achilleas-k
Copy link
Member

I think we need to bump the repo snapshots for 9.5 and c9s as well. The new osbuild rpms need a newer selinux-policy.

achilleas-k
achilleas-k previously approved these changes Aug 22, 2024
@thozza
Copy link
Member Author

thozza commented Aug 22, 2024

The c10s installer test won't pass due to https://issues.redhat.com/browse/RHEL-47274 and our latest snapshot not having the latest selinux-policy build 🤦

Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
@achilleas-k achilleas-k merged commit a920b39 into osbuild:main Aug 23, 2024
46 of 50 checks passed
@thozza thozza deleted the COMPOSER-2193 branch August 26, 2024 07:50
thozza added a commit to thozza/image-builder that referenced this pull request Aug 26, 2024
These were added by [1], so let's enable them in the service.

[1] osbuild/osbuild-composer#4314

Signed-off-by: Tomáš Hozza <thozza@redhat.com>
thozza added a commit to osbuild/image-builder that referenced this pull request Aug 27, 2024
These were added by [1], so let's enable them in the service.

[1] osbuild/osbuild-composer#4314

Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants