Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker: simplify the POST in workerHeartbeat() #4327

Merged
merged 1 commit into from
Aug 26, 2024
Merged

worker: simplify the POST in workerHeartbeat() #4327

merged 1 commit into from
Aug 26, 2024

Conversation

mvo5
Copy link
Contributor

@mvo5 mvo5 commented Aug 26, 2024

There is no actual payload when posting the worker status so let's just post nil instead of an empty bytes.Buffer to make this explicit.

@mvo5
worker: simplify the POST in workerHeartbeat()
bba296d 
There is no actual payload when posting the worker status so let's
just post `nil` instead of an empty `bytes.Buffer` to make this
explicit.
@mvo5 mvo5 requested a review from croissanne August 26, 2024 11:57
@mvo5 mvo5 merged commit 43c6bc7 into osbuild:main Aug 26, 2024
45 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schuellerf schuellerf schuellerf approved these changes

@croissanne croissanne croissanne approved these changes

Assignees
No one assigned
Labels
🍼 Simple
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvo5 @schuellerf @croissanne