upload/azure: turn off public access on storage accounts

[croissanne]

When creating a storage account we're currently allowing public blob access, users might have compliance policies active on their azure accounts which forbid this.

---

Even though the default should be false, we're still getting

Storage account Allow Blob Public Access should be disallowed

so let's just do it explicitly.

[croissanne]

For testing I disabled public blob access on all our storage accounts, so if the azure tests are green it should be fine.

[ondrejbudai]

Awesome! :) Btw, they can also create the storage account themselves if they want, they just need to tag it correctly so osbuild-composer finds it.

[achilleas-k]

Awesome! :) Btw, they can also create the storage account themselves if they want, they just need to tag it correctly so osbuild-composer finds it.

Should this be documented in the release notes? We can add instructions for how to get the old behaviour by creating the storage beforehand.

[croissanne]

Awesome! :) Btw, they can also create the storage account themselves if they want, they just need to tag it correctly so osbuild-composer finds it.

Indeed, but this particular user is having trouble with that. I don't fully understand why because it looks properly tagged "imageBuilderStorageAccount": "location=eastus", but still it was trying to create a storage account.