Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump github.com/onsi/ginkgo/v2 from 2.10.0 to 2.11.0 in /tools #3189

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 19, 2023

Bumps github.com/onsi/ginkgo/v2 from 2.10.0 to 2.11.0.

Release notes

Sourced from github.com/onsi/ginkgo/v2's releases.

v2.11.0

2.11.0

In prior versions of Ginkgo specs the CLI filter flags (e.g. --focus, --label-filter) would override any programmatic focus. This behavior has proved surprising and confusing in at least the following ways:

  • users cannot combine programmatic filters and CLI filters to more efficiently select subsets of tests
  • CLI filters can override programmatic focus on CI systems resulting in an exit code of 0 despite the presence of (incorrectly!) committed focused specs.

Going forward Ginkgo will AND all programmatic and CLI filters. Moreover, the presence of any programmatic focused tests will always result in a non-zero exit code.

This change is technically a change in Ginkgo's external contract and may require some users to make changes to successfully adopt. Specifically: it's possible some users were intentionally using CLI filters to override programmatic focus. If this is you please open an issue so we can explore solutions to the underlying problem you are trying to solve.

Fixes

  • Programmatic focus is no longer overwrriten by CLI filters [d6bba86]

Maintenance

  • Bump github.com/onsi/gomega from 1.27.7 to 1.27.8 (#1218) [4a70a38]
  • Bump golang.org/x/sys from 0.8.0 to 0.9.0 (#1219) [97eda4d]
Changelog

Sourced from github.com/onsi/ginkgo/v2's changelog.

2.11.0

In prior versions of Ginkgo specs the CLI filter flags (e.g. --focus, --label-filter) would override any programmatic focus. This behavior has proved surprising and confusing in at least the following ways:

  • users cannot combine programmatic filters and CLI filters to more efficiently select subsets of tests
  • CLI filters can override programmatic focus on CI systems resulting in an exit code of 0 despite the presence of (incorrectly!) committed focused specs.

Going forward Ginkgo will AND all programmatic and CLI filters. Moreover, the presence of any programmatic focused tests will always result in a non-zero exit code.

This change is technically a change in Ginkgo's external contract and may require some users to make changes to successfully adopt. Specifically: it's possible some users were intentionally using CLI filters to override programmatic focus. If this is you please open an issue so we can explore solutions to the underlying problem you are trying to solve.

Fixes

  • Programmatic focus is no longer overwrriten by CLI filters [d6bba86]

Maintenance

  • Bump github.com/onsi/gomega from 1.27.7 to 1.27.8 (#1218) [4a70a38]
  • Bump golang.org/x/sys from 0.8.0 to 0.9.0 (#1219) [97eda4d]
Commits
  • 5c32b2a v2.11.0
  • d6bba86 Programmatic focus is no longer overwrriten by CLI filters
  • 4a70a38 Bump github.com/onsi/gomega from 1.27.7 to 1.27.8 (#1218)
  • 97eda4d Bump golang.org/x/sys from 0.8.0 to 0.9.0 (#1219)
  • See full diff in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot will merge this PR once it's up-to-date and CI passes on it, as requested by @naveensrinivasan.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jun 19, 2023
@dependabot dependabot bot temporarily deployed to integration-test June 19, 2023 09:03 Inactive
@naveensrinivasan
Copy link
Member

@dependabot rebase

@naveensrinivasan
Copy link
Member

@dependabot merge

@dependabot dependabot bot force-pushed the dependabot/go_modules/tools/github.com/onsi/ginkgo/v2-2.11.0 branch from 952ffc0 to 4833c6b Compare June 20, 2023 19:41
@dependabot dependabot bot temporarily deployed to integration-test June 20, 2023 19:43 Inactive
Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.10.0 to 2.11.0.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.10.0...v2.11.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/tools/github.com/onsi/ginkgo/v2-2.11.0 branch from 4833c6b to 00cbf89 Compare June 20, 2023 19:43
@dependabot dependabot bot temporarily deployed to integration-test June 20, 2023 19:44 Inactive
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #3189 (00cbf89) into main (a50bc07) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3189   +/-   ##
=======================================
  Coverage   62.74%   62.74%           
=======================================
  Files         168      168           
  Lines       12586    12586           
=======================================
  Hits         7897     7897           
  Misses       4259     4259           
  Partials      430      430           

@dependabot dependabot bot merged commit efcbc72 into main Jun 20, 2023
37 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/tools/github.com/onsi/ginkgo/v2-2.11.0 branch June 20, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant