[Bug-fix] Refactor warning about global normalization to forecaster.py (

#1109)
ourownstory · Jan 13, 2023 · 05d5e10 · 05d5e10
1 parent ebbe06a
commit 05d5e10
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/neuralprophet/forecaster.py b/neuralprophet/forecaster.py
@@ -759,6 +759,9 @@ def fit(
             log.warning("Progress plot requires metrics to be enabled. Enabling the default metrics.")
             metrics = metrics.get_metrics(True)
 
+        if not self.config_normalization.global_normalization:
+            log.warning("When Global modeling with local normalization, metrics are displayed in normalized scale.")
+
         if minimal:
             checkpointing = False
             self.metrics = False

diff --git a/neuralprophet/time_net.py b/neuralprophet/time_net.py
@@ -1290,9 +1290,7 @@ def denormalize(self, ts):
         -------
             denormalized timeseries
         """
-        if not self.config_normalization.global_normalization:
-            log.warning("When Global modeling with local normalization, metrics are displayed in normalized scale.")
-        else:
+        if self.config_normalization.global_normalization:
             shift_y = (
                 self.config_normalization.global_data_params["y"].shift
                 if self.config_normalization.global_normalization and not self.config_normalization.normalize == "off"