Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change plotting_backend deprecation warning for implicit and explicit matplotlib use #1006

Merged
merged 6 commits into from
Dec 2, 2022

Conversation

LeonieFreisinger
Copy link
Collaborator

@LeonieFreisinger LeonieFreisinger commented Nov 30, 2022

referring Issue: #998

Key Changes:

  • outsourced warning message in plot_utils.py
  • implement warning message to be shown for matplotlib on every plot function that the user can call.

Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added Docstrings and data types to function definitions.
  • My code follows the style guidelines described under CONTRIBUTING.md.
  • I have added pytests to check whether my feature / fix works
  • All gh actions pass or the failure is not related to my code.

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2022

Codecov Report

Merging #1006 (9592225) into main (5290746) will increase coverage by 0.03%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main    #1006      +/-   ##
==========================================
+ Coverage   90.17%   90.21%   +0.03%     
==========================================
  Files          20       20              
  Lines        4734     4740       +6     
==========================================
+ Hits         4269     4276       +7     
+ Misses        465      464       -1     
Impacted Files Coverage Δ
neuralprophet/forecaster.py 88.45% <83.33%> (+0.15%) ⬆️
neuralprophet/plot_utils.py 89.91% <100.00%> (+0.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@LeonieFreisinger LeonieFreisinger added the status: needs review PR needs to be reviewed by Reviewer(s) label Dec 1, 2022
@LeonieFreisinger
Copy link
Collaborator Author

@noxan changed the warning to be displayed for any matplotlib plotting. Would be great if you can review it. P.S. I allocated the warning message in the plot_utils.py, since it is used multiple times. For having an overview of warning messages, I think it would be generally nice to have them all in one place, e.g. in a utils.py. However, it might as well be a little overkill if some cases have a warning message that is only used once. What do you think?

Copy link
Collaborator

@noxan noxan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, so little code - love how efficiently you tackled the issue 👏

We might need to resolve the merge conflict, if you find time would be awesome, otherwise I'll check tomorrow.

@noxan noxan added status: ready PR is ready to be merged and removed status: needs review PR needs to be reviewed by Reviewer(s) labels Dec 1, 2022
@noxan noxan marked this pull request as ready for review December 1, 2022 19:55
neuralprophet/plot_utils.py Outdated Show resolved Hide resolved
@noxan noxan added this to the Release 0.5.0 milestone Dec 2, 2022
@noxan noxan merged commit af98e9d into ourownstory:main Dec 2, 2022
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

af98e9d

Model Benchmark

Benchmark Metric main current diff
YosemiteTemps MAE_val 1.72949 1.72949 0.0%
YosemiteTemps RMSE_val 2.27386 2.27386 0.0%
YosemiteTemps Loss_val 0.00096 0.00096 0.0%
YosemiteTemps RegLoss_val 0 0 0.0%
YosemiteTemps epoch 84 84 0.0%
YosemiteTemps MAE 1.45189 1.45189 0.0%
YosemiteTemps RMSE 2.16631 2.16631 0.0%
YosemiteTemps Loss 0.00066 0.00066 0.0%
YosemiteTemps RegLoss 0 0 0.0%
YosemiteTemps time 106.89 102.16 -4.43%
PeytonManning MAE_val 0.64636 0.64636 0.0%
PeytonManning RMSE_val 0.79276 0.79276 0.0%
PeytonManning Loss_val 0.01494 0.01494 0.0%
PeytonManning RegLoss_val 0 0 0.0%
PeytonManning epoch 37 37 0.0%
PeytonManning MAE 0.42701 0.42701 0.0%
PeytonManning RMSE 0.57032 0.57032 0.0%
PeytonManning Loss 0.00635 0.00635 0.0%
PeytonManning RegLoss 0 0 0.0%
PeytonManning time 12.65 12.59 -0.47%
AirPassengers MAE_val 15.2698 15.2698 0.0%
AirPassengers RMSE_val 19.4209 19.4209 0.0%
AirPassengers Loss_val 0.00195 0.00195 0.0%
AirPassengers RegLoss_val 0 0 0.0%
AirPassengers epoch 89 89 0.0%
AirPassengers MAE 9.82902 9.82902 0.0%
AirPassengers RMSE 11.7005 11.7005 0.0%
AirPassengers Loss 0.00056 0.00056 0.0%
AirPassengers RegLoss 0 0 0.0%
AirPassengers time 4.97 4.8 -3.42%
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@LeonieFreisinger LeonieFreisinger linked an issue Dec 2, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready PR is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add deprecation warning for matplotlib
3 participants