-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change plotting_backend deprecation warning for implicit and explicit matplotlib use #1006
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1006 +/- ##
==========================================
+ Coverage 90.17% 90.21% +0.03%
==========================================
Files 20 20
Lines 4734 4740 +6
==========================================
+ Hits 4269 4276 +7
+ Misses 465 464 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@noxan changed the warning to be displayed for any matplotlib plotting. Would be great if you can review it. P.S. I allocated the warning message in the plot_utils.py, since it is used multiple times. For having an overview of warning messages, I think it would be generally nice to have them all in one place, e.g. in a utils.py. However, it might as well be a little overkill if some cases have a warning message that is only used once. What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, so little code - love how efficiently you tackled the issue 👏
We might need to resolve the merge conflict, if you find time would be awesome, otherwise I'll check tomorrow.
Model Benchmark
|
referring Issue: #998
Key Changes:
Review Checklist