Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Remove duplicate season reg lambda #1020

Merged
merged 6 commits into from
Dec 3, 2022

Conversation

noxan
Copy link
Collaborator

@noxan noxan commented Dec 2, 2022

Remove the config_train.reg_lambda_season as it is only a duplicate of config_season.reg_lambda

@github-actions
Copy link

github-actions bot commented Dec 2, 2022

33cb441

Model Benchmark

Benchmark Metric main current diff
AirPassengers MAE_val 15.2698 15.2698 0.0%
AirPassengers RMSE_val 19.4209 19.4209 0.0%
AirPassengers Loss_val 0.00195 0.00195 0.0%
AirPassengers RegLoss_val 0 0 0.0%
AirPassengers epoch 89 89 0.0%
AirPassengers MAE 9.82902 9.82902 0.0%
AirPassengers RMSE 11.7005 11.7005 0.0%
AirPassengers Loss 0.00056 0.00056 0.0%
AirPassengers RegLoss 0 0 0.0%
AirPassengers time 4.94 7.09 43.52% ⚠️
PeytonManning MAE_val 0.64636 0.64636 -0.0%
PeytonManning RMSE_val 0.79276 0.79276 -0.0%
PeytonManning Loss_val 0.01494 0.01494 -0.0%
PeytonManning RegLoss_val 0 0 0.0%
PeytonManning epoch 37 37 0.0%
PeytonManning MAE 0.42701 0.42701 0.0%
PeytonManning RMSE 0.57032 0.57032 -0.0%
PeytonManning Loss 0.00635 0.00635 0.0%
PeytonManning RegLoss 0 0 0.0%
PeytonManning time 12.51 18.31 46.36% ⚠️
YosemiteTemps MAE_val 1.72949 1.72948 -0.0%
YosemiteTemps RMSE_val 2.27386 2.27386 -0.0%
YosemiteTemps Loss_val 0.00096 0.00096 -0.0%
YosemiteTemps RegLoss_val 0 0 0.0%
YosemiteTemps epoch 84 84 0.0%
YosemiteTemps MAE 1.45189 1.45189 -0.0%
YosemiteTemps RMSE 2.16631 2.16631 -0.0%
YosemiteTemps Loss 0.00066 0.00066 0.0%
YosemiteTemps RegLoss 0 0 0.0%
YosemiteTemps time 101.63 148 45.63% ⚠️
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2022

Codecov Report

Merging #1020 (1a8f8fc) into main (6131069) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #1020      +/-   ##
==========================================
- Coverage   90.26%   90.26%   -0.01%     
==========================================
  Files          21       21              
  Lines        4737     4736       -1     
==========================================
- Hits         4276     4275       -1     
  Misses        461      461              
Impacted Files Coverage Δ
neuralprophet/configure.py 90.29% <ø> (-0.04%) ⬇️
neuralprophet/forecaster.py 88.44% <ø> (-0.02%) ⬇️
neuralprophet/time_net.py 90.59% <50.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@noxan noxan added the status: needs review PR needs to be reviewed by Reviewer(s) label Dec 2, 2022
@noxan noxan requested a review from judussoari December 3, 2022 03:02
@noxan noxan added this to the Release 0.5.0 milestone Dec 3, 2022
Copy link
Collaborator

@judussoari judussoari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@judussoari judussoari added status: ready PR is ready to be merged and removed status: needs review PR needs to be reviewed by Reviewer(s) labels Dec 3, 2022
@noxan noxan merged commit 2154c26 into main Dec 3, 2022
@noxan noxan deleted the refactor/remove-duplicate-season-reg-lambda branch December 3, 2022 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready PR is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants