Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restict numpy version to <1.24.0 #1080

Merged
merged 2 commits into from
Dec 21, 2022
Merged

Restict numpy version to <1.24.0 #1080

merged 2 commits into from
Dec 21, 2022

Conversation

karl-richter
Copy link
Collaborator

🔬 Background

Numpy 1.24.0 seems to cause problem with the matplotlib plotting engine. Thus, we restrict numpy to <1.24.0 for the time being.

🔮 Key changes

Restrict numpy to <1.24.0

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

Please make sure to follow our best practices in the Contributing guidelines.

@karl-richter karl-richter self-assigned this Dec 21, 2022
@karl-richter karl-richter added type:bug Something isn't working priority:P1 High priority status: needs review PR needs to be reviewed by Reviewer(s) labels Dec 21, 2022
@github-actions
Copy link

github-actions bot commented Dec 21, 2022

5bf8c66

Model Benchmark

Benchmark Metric main current diff
AirPassengers MAE_val 15.2698 15.2698 0.0%
AirPassengers RMSE_val 19.4209 19.4209 0.0%
AirPassengers Loss_val 0.00195 0.00195 0.0%
AirPassengers MAE 9.82902 9.82902 0.0%
AirPassengers RMSE 11.7005 11.7005 0.0%
AirPassengers Loss 0.00056 0.00056 0.0%
AirPassengers time 4.09719 4.16 1.53%
YosemiteTemps MAE_val 1.72949 1.72949 0.0%
YosemiteTemps RMSE_val 2.27386 2.27386 0.0%
YosemiteTemps Loss_val 0.00096 0.00096 0.0%
YosemiteTemps MAE 1.45189 1.45189 0.0%
YosemiteTemps RMSE 2.16631 2.16631 0.0%
YosemiteTemps Loss 0.00066 0.00066 0.0%
YosemiteTemps time 91.1997 92.59 1.52%
PeytonManning MAE_val 0.64636 0.64636 0.0%
PeytonManning RMSE_val 0.79276 0.79276 0.0%
PeytonManning Loss_val 0.01494 0.01494 0.0%
PeytonManning MAE 0.42701 0.42701 0.0%
PeytonManning RMSE 0.57032 0.57032 0.0%
PeytonManning Loss 0.00635 0.00635 0.0%
PeytonManning time 11.5013 11.38 -1.05%
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2022

Codecov Report

Merging #1080 (5bf8c66) into main (1cf4a93) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1080   +/-   ##
=======================================
  Coverage   89.98%   89.98%           
=======================================
  Files          21       21           
  Lines        4784     4784           
=======================================
  Hits         4305     4305           
  Misses        479      479           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Kevin-Chen0 Kevin-Chen0 merged commit ae341cd into main Dec 21, 2022
@Kevin-Chen0 Kevin-Chen0 deleted the fix/numpy_version branch December 21, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:P1 High priority status: needs review PR needs to be reviewed by Reviewer(s) type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants