Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing conformal prediction #1124

Merged
merged 6 commits into from
Jan 29, 2023
Merged

Typing conformal prediction #1124

merged 6 commits into from
Jan 29, 2023

Conversation

noxan
Copy link
Collaborator

@noxan noxan commented Jan 19, 2023

🔬 Background

  • Add typings for NeuralProphet

🔮 Key changes

  • Add type annotations to conformal prediction code

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

Please make sure to follow our best practices in the Contributing guidelines.

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2023

Codecov Report

Merging #1124 (d39591b) into main (81cbbfc) will decrease coverage by 0.02%.
The diff coverage is 80.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1124      +/-   ##
==========================================
- Coverage   90.36%   90.34%   -0.02%     
==========================================
  Files          21       21              
  Lines        4845     4846       +1     
==========================================
  Hits         4378     4378              
- Misses        467      468       +1     
Impacted Files Coverage Δ
neuralprophet/conformal.py 95.31% <80.00%> (-1.52%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@karl-richter karl-richter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@karl-richter karl-richter added refactoring status: ready PR is ready to be merged labels Jan 28, 2023
@karl-richter karl-richter added this to the Release 0.5.2 milestone Jan 28, 2023
@github-actions
Copy link

github-actions bot commented Jan 28, 2023

Model Benchmark

Benchmark Metric main current diff
PeytonManning MAE_val 0.64636 0.64636 0.0%
PeytonManning RMSE_val 0.79276 0.79276 0.0%
PeytonManning Loss_val 0.01494 0.01494 0.0%
PeytonManning MAE 0.42701 0.42701 0.0%
PeytonManning RMSE 0.57032 0.57032 0.0%
PeytonManning Loss 0.00635 0.00635 0.0%
PeytonManning time 11.2836 11.42 1.21%
YosemiteTemps MAE_val 1.72949 1.72949 0.0%
YosemiteTemps RMSE_val 2.27386 2.27386 0.0%
YosemiteTemps Loss_val 0.00096 0.00096 0.0%
YosemiteTemps MAE 1.45189 1.45189 0.0%
YosemiteTemps RMSE 2.16631 2.16631 0.0%
YosemiteTemps Loss 0.00066 0.00066 0.0%
YosemiteTemps time 90.1156 91.46 1.49%
AirPassengers MAE_val 15.2698 15.2698 0.0%
AirPassengers RMSE_val 19.4209 19.4209 0.0%
AirPassengers Loss_val 0.00195 0.00195 0.0%
AirPassengers MAE 9.82902 9.82902 0.0%
AirPassengers RMSE 11.7005 11.7005 0.0%
AirPassengers Loss 0.00056 0.00056 0.0%
AirPassengers time 4.00096 4.1 2.48%
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@karl-richter karl-richter merged commit 39a6a86 into main Jan 29, 2023
@karl-richter karl-richter deleted the typing-conformal-prediction branch January 29, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready PR is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants