Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] default value of n_changepoints given correctly in the docs #1128

Merged
merged 3 commits into from
Feb 27, 2023

Conversation

leoniewgnr
Copy link
Collaborator

🔬 Background

In the guide hyperparemeter-selection, it says
'n_changepoints is the number of changepoints selected along the series for the trend. The default value for this is 5.'
But the correct value would be 10, being consistent with the code.

🔮 Key changes

Changed the value of 5 to 10 in the guide

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

@leoniewgnr leoniewgnr marked this pull request as ready for review January 23, 2023 20:49
Copy link
Collaborator

@LeonieFreisinger LeonieFreisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you :)

@leoniewgnr leoniewgnr added the status: ready PR is ready to be merged label Feb 11, 2023
@noxan noxan changed the title default value of n_changepoints given correctly in the docs [fix] default value of n_changepoints given correctly in the docs Feb 27, 2023
Copy link
Collaborator

@noxan noxan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating

@noxan noxan merged commit 24cf95e into ourownstory:main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready PR is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants