Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Remove unneeded logs #1207

Merged
merged 2 commits into from
Apr 7, 2023
Merged

[tests] Remove unneeded logs #1207

merged 2 commits into from
Apr 7, 2023

Conversation

karl-richter
Copy link
Collaborator

🔬 Background

  • The pytests log very verbose, remove logs to improve readbility.

🔮 Key changes

  • ...

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

Please make sure to follow our best practices in the Contributing guidelines.

@karl-richter karl-richter self-assigned this Mar 8, 2023
@karl-richter karl-richter added this to the Release 0.5.4 milestone Mar 8, 2023
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Model Benchmark

Benchmark Metric main current diff
AirPassengers MAE_val 15.2698 15.2698 0.0%
AirPassengers RMSE_val 19.4209 19.4209 0.0%
AirPassengers Loss_val 0.00195 0.00195 0.0%
AirPassengers MAE 9.82902 9.82902 0.0%
AirPassengers RMSE 11.7005 11.7005 0.0%
AirPassengers Loss 0.00056 0.00056 0.0%
AirPassengers time 5.0434 5.09 0.92%
YosemiteTemps MAE_val 1.71298 1.71298 0.0%
YosemiteTemps RMSE_val 2.2607 2.2607 0.0%
YosemiteTemps Loss_val 0.00095 0.00095 0.0%
YosemiteTemps MAE 1.45187 1.45187 0.0%
YosemiteTemps RMSE 2.16721 2.16721 0.0%
YosemiteTemps Loss 0.00066 0.00066 0.0%
YosemiteTemps time 115.093 118.16 2.66%
PeytonManning MAE_val 0.58159 0.58159 0.0%
PeytonManning RMSE_val 0.72216 0.72216 0.0%
PeytonManning Loss_val 0.01239 0.01239 0.0%
PeytonManning MAE 0.41671 0.41671 0.0%
PeytonManning RMSE 0.55961 0.55961 0.0%
PeytonManning Loss 0.00612 0.00612 0.0%
PeytonManning time 14.5301 14.18 -2.41%
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@karl-richter karl-richter added the task Tasks (not an epic, not a bug) label Mar 8, 2023
@karl-richter karl-richter changed the title Cleanup Pytests [tests] Remove unneeded logs Mar 8, 2023
Copy link
Collaborator

@LeonieFreisinger LeonieFreisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree! Removed logs will definitely make our code more lean.

@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2023

Codecov Report

Merging #1207 (80241f2) into main (f61527a) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #1207   +/-   ##
=======================================
  Coverage   89.56%   89.56%           
=======================================
  Files          35       35           
  Lines        4830     4830           
=======================================
  Hits         4326     4326           
  Misses        504      504           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@LeonieFreisinger LeonieFreisinger merged commit bcb7f20 into main Apr 7, 2023
@LeonieFreisinger LeonieFreisinger deleted the cleanup/tests branch April 7, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Tasks (not an epic, not a bug)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants