Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Modified n_forecasts in _infer_evaluate_params_from_dataset() method in conformal.py #1212

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

Kevin-Chen0
Copy link
Collaborator

@Kevin-Chen0 Kevin-Chen0 commented Mar 13, 2023

🔬 Background

  • Allows conformal evaluation for double-digit (and beyond) multistep forecasting.

🔮 Key changes

  • Change the way how n_forecasts is extracted.

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

Please make sure to follow our best practices in the Contributing guidelines.

@Kevin-Chen0 Kevin-Chen0 self-assigned this Mar 13, 2023
@Kevin-Chen0 Kevin-Chen0 changed the title Modified n_forecasts in _infer_evaluate_params_from_dataset() method in conformal.py [refactor] Modified n_forecasts in _infer_evaluate_params_from_dataset() method in conformal.py Mar 13, 2023
@Kevin-Chen0 Kevin-Chen0 added status: needs review PR needs to be reviewed by Reviewer(s) priority:P2 Medium priority labels Mar 13, 2023
@github-actions
Copy link

github-actions bot commented Mar 13, 2023

Model Benchmark

Benchmark Metric main current diff
YosemiteTemps MAE_val 1.71298 1.71298 -0.0%
YosemiteTemps RMSE_val 2.2607 2.26069 -0.0%
YosemiteTemps Loss_val 0.00095 0.00095 -0.0%
YosemiteTemps MAE 1.45187 1.45187 0.0%
YosemiteTemps RMSE 2.16721 2.16721 -0.0%
YosemiteTemps Loss 0.00066 0.00066 -0.0%
YosemiteTemps time 124.033 159.3 28.43%
PeytonManning MAE_val 0.58159 0.58159 0.0%
PeytonManning RMSE_val 0.72216 0.72216 0.0%
PeytonManning Loss_val 0.01239 0.01239 0.0%
PeytonManning MAE 0.41671 0.41671 0.0%
PeytonManning RMSE 0.55961 0.55961 -0.0%
PeytonManning Loss 0.00612 0.00612 -0.0%
PeytonManning time 15.9016 19.25 21.06%
AirPassengers MAE_val 15.2698 15.2698 0.0%
AirPassengers RMSE_val 19.4209 19.4209 0.0%
AirPassengers Loss_val 0.00195 0.00195 0.0%
AirPassengers MAE 9.82902 9.82902 0.0%
AirPassengers RMSE 11.7005 11.7005 0.0%
AirPassengers Loss 0.00056 0.00056 0.0%
AirPassengers time 5.28984 6.79 28.36%
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2023

Codecov Report

Merging #1212 (298c015) into main (7a1c6b2) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #1212   +/-   ##
=======================================
  Coverage   89.55%   89.55%           
=======================================
  Files          35       35           
  Lines        4808     4808           
=======================================
  Hits         4306     4306           
  Misses        502      502           
Impacted Files Coverage Δ
neuralprophet/conformal.py 97.05% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@leoniewgnr leoniewgnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Kevin-Chen0 Kevin-Chen0 force-pushed the refactor/_infer_evaluate_params_from_dataset branch from 298c015 to 9a3f4c0 Compare March 13, 2023 17:17
@Kevin-Chen0 Kevin-Chen0 removed the request for review from christymctse March 13, 2023 17:18
@Kevin-Chen0 Kevin-Chen0 merged commit facaf60 into main Mar 13, 2023
@Kevin-Chen0 Kevin-Chen0 deleted the refactor/_infer_evaluate_params_from_dataset branch March 13, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:P2 Medium priority status: needs review PR needs to be reviewed by Reviewer(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants