Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Add quantile regression (QR) as an uncertainty evalution metric in uncertainty.py #1214

Merged
merged 3 commits into from
Mar 14, 2023

Conversation

Kevin-Chen0
Copy link
Collaborator

@Kevin-Chen0 Kevin-Chen0 commented Mar 14, 2023

🔬 Background

  • Added QR so its uncertainty metrics interval_width can also be compared to the conformal prediction (CP) metrics.

🔮 Key changes

  • Included QR into the uncertainty_evaluate() method in uncertainty.py.

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

Please make sure to follow our best practices in the Contributing guidelines.

@Kevin-Chen0 Kevin-Chen0 self-assigned this Mar 14, 2023
@Kevin-Chen0 Kevin-Chen0 added status: needs review PR needs to be reviewed by Reviewer(s) priority:P2 Medium priority labels Mar 14, 2023
@Kevin-Chen0 Kevin-Chen0 changed the title Refactor/uncertainty evaluate qr [refactor] Add quantile regression (QR) as an uncertainty evalution metric in uncertainty.py Mar 14, 2023
@github-actions
Copy link

github-actions bot commented Mar 14, 2023

Model Benchmark

Benchmark Metric main current diff
YosemiteTemps MAE_val 1.71298 1.71298 -0.0%
YosemiteTemps RMSE_val 2.2607 2.26069 -0.0%
YosemiteTemps Loss_val 0.00095 0.00095 -0.0%
YosemiteTemps MAE 1.45187 1.45187 0.0%
YosemiteTemps RMSE 2.16721 2.16721 -0.0%
YosemiteTemps Loss 0.00066 0.00066 -0.0%
YosemiteTemps time 120.838 163.59 35.38%
PeytonManning MAE_val 0.58159 0.58159 0.0%
PeytonManning RMSE_val 0.72216 0.72216 0.0%
PeytonManning Loss_val 0.01239 0.01239 0.0%
PeytonManning MAE 0.41671 0.41671 0.0%
PeytonManning RMSE 0.55961 0.55961 -0.0%
PeytonManning Loss 0.00612 0.00612 -0.0%
PeytonManning time 15.1375 20.04 32.39%
AirPassengers MAE_val 15.2698 15.2698 0.0%
AirPassengers RMSE_val 19.4209 19.4209 0.0%
AirPassengers Loss_val 0.00195 0.00195 0.0%
AirPassengers MAE 9.82902 9.82902 0.0%
AirPassengers RMSE 11.7005 11.7005 0.0%
AirPassengers Loss 0.00056 0.00056 0.0%
AirPassengers time 5.12103 7.14 39.43%
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2023

Codecov Report

Merging #1214 (c66fada) into main (facaf60) will increase coverage by 0.00%.
The diff coverage is 96.29%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #1214   +/-   ##
=======================================
  Coverage   89.55%   89.56%           
=======================================
  Files          35       35           
  Lines        4808     4830   +22     
=======================================
+ Hits         4306     4326   +20     
- Misses        502      504    +2     
Impacted Files Coverage Δ
neuralprophet/uncertainty.py 95.96% <96.29%> (-1.10%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Kevin-Chen0 Kevin-Chen0 mentioned this pull request Mar 14, 2023
11 tasks
Copy link
Collaborator

@christymctse christymctse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christymctse christymctse merged commit 03726d3 into main Mar 14, 2023
@christymctse christymctse deleted the refactor/uncertainty_evaluate_qr branch March 14, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:P2 Medium priority status: needs review PR needs to be reviewed by Reviewer(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants