Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Limit broken dependency versions (mainly pytorch < 2.0) #1221

Merged
merged 4 commits into from
Mar 17, 2023

Conversation

noxan
Copy link
Collaborator

@noxan noxan commented Mar 16, 2023

🔬 Background

🔮 Key changes

  • Limit version of pytorch to <2.0
  • Limit version of pytorch-lightning to <2.0.0
  • Limit version of dash to <2.9 (dependency of plotly)

🚀 How to install

pip install git+https://github.com/ourownstory/neural_prophet.git@fix-broken-pytorch

⚠️ Unresolved issues

  • Github actions fails with a RuntimeError: wrap_controller at 'pytest_runtest_makereport' /opt/hostedtoolcache/Python/3.7.16/x64/lib/python3.7/site-packages/dash/testing/plugin.py:106 did not yield
  • Had a AttributeError: 'ProgressBar' object has no attribute 'main_progress_bar' error locally but could not reproduce it with a new python install

@noxan noxan changed the title limit pytorch version to 1.x [fix] Limit pytorch version to 1.x Mar 16, 2023
@noxan noxan changed the title [fix] Limit pytorch version to 1.x [fix] Limit broken dependency versions (mainly pytorch < 2.0) Mar 16, 2023
@github-actions
Copy link

Model Benchmark

Benchmark Metric main current diff
YosemiteTemps MAE_val 1.71298 1.71298 0.0%
YosemiteTemps RMSE_val 2.26069 2.26069 0.0%
YosemiteTemps Loss_val 0.00095 0.00095 0.0%
YosemiteTemps MAE 1.45187 1.45187 0.0%
YosemiteTemps RMSE 2.16721 2.16721 0.0%
YosemiteTemps Loss 0.00066 0.00066 0.0%
YosemiteTemps time 156.435 163.26 4.36% ⚠️
AirPassengers MAE_val 15.2698 15.2698 0.0%
AirPassengers RMSE_val 19.4209 19.4209 0.0%
AirPassengers Loss_val 0.00195 0.00195 0.0%
AirPassengers MAE 9.82902 9.82902 0.0%
AirPassengers RMSE 11.7005 11.7005 0.0%
AirPassengers Loss 0.00056 0.00056 0.0%
AirPassengers time 7.1644 6.94 -3.13%
PeytonManning MAE_val 0.58159 0.58159 0.0%
PeytonManning RMSE_val 0.72216 0.72216 0.0%
PeytonManning Loss_val 0.01239 0.01239 0.0%
PeytonManning MAE 0.41671 0.41671 0.0%
PeytonManning RMSE 0.55961 0.55961 0.0%
PeytonManning Loss 0.00612 0.00612 0.0%
PeytonManning time 19.4037 19.72 1.63%
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@codecov-commenter
Copy link

Codecov Report

Merging #1221 (7c4db5b) into main (03726d3) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #1221   +/-   ##
=======================================
  Coverage   89.56%   89.56%           
=======================================
  Files          35       35           
  Lines        4830     4830           
=======================================
  Hits         4326     4326           
  Misses        504      504           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@LeonieFreisinger LeonieFreisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with python 3.10. All tests pass.

@noxan noxan merged commit f57f8eb into main Mar 17, 2023
@noxan noxan deleted the fix-broken-pytorch branch March 17, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants