Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Changed int() to round() for q_hat_idx in uncertainty.py. #1248

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

Kevin-Chen0
Copy link
Collaborator

@Kevin-Chen0 Kevin-Chen0 commented Apr 5, 2023

🔬 Background

  • Why is this change needed? Is there a related issue or a new feature to be added?

🔮 Key changes

  • Explain the main changes introduced by this pull request for the reviewer.

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

Please make sure to follow our best practices in the Contributing guidelines.

@Kevin-Chen0 Kevin-Chen0 added type:bug Something isn't working priority:P2 Medium priority labels Apr 5, 2023
@Kevin-Chen0 Kevin-Chen0 self-assigned this Apr 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2023

Codecov Report

Merging #1248 (e4b8373) into main (e321e96) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #1248   +/-   ##
=======================================
  Coverage   89.56%   89.56%           
=======================================
  Files          35       35           
  Lines        4830     4830           
=======================================
  Hits         4326     4326           
  Misses        504      504           
Impacted Files Coverage Δ
neuralprophet/uncertainty.py 95.96% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

Model Benchmark

Benchmark Metric main current diff
YosemiteTemps MAE_val 1.71298 1.71298 0.0%
YosemiteTemps RMSE_val 2.26069 2.2607 0.0%
YosemiteTemps Loss_val 0.00095 0.00095 0.0%
YosemiteTemps MAE 1.45187 1.45187 -0.0%
YosemiteTemps RMSE 2.16721 2.16721 0.0%
YosemiteTemps Loss 0.00066 0.00066 0.0%
YosemiteTemps time 115.403 92.84 -19.55% 🎉
AirPassengers MAE_val 15.2698 15.2698 0.0%
AirPassengers RMSE_val 19.4209 19.4209 0.0%
AirPassengers Loss_val 0.00195 0.00195 0.0%
AirPassengers MAE 9.82902 9.82902 0.0%
AirPassengers RMSE 11.7005 11.7005 0.0%
AirPassengers Loss 0.00056 0.00056 0.0%
AirPassengers time 5.10672 4.05 -20.69% 🎉
PeytonManning MAE_val 0.58159 0.58159 -0.0%
PeytonManning RMSE_val 0.72216 0.72216 0.0%
PeytonManning Loss_val 0.01239 0.01239 -0.0%
PeytonManning MAE 0.41671 0.41671 -0.0%
PeytonManning RMSE 0.55961 0.55961 0.0%
PeytonManning Loss 0.00612 0.00612 0.0%
PeytonManning time 14.1839 11.76 -17.09% 🎉
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@christymctse christymctse self-requested a review April 6, 2023 05:12
Copy link
Collaborator

@christymctse christymctse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:P2 Medium priority type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] No intersection of coverage error and empirical quantile on conformity score
6 participants