-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] Uncertainty streamline naming #1262
Conversation
Model Benchmark
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1262 +/- ##
==========================================
- Coverage 89.84% 89.79% -0.05%
==========================================
Files 38 38
Lines 5149 5126 -23
==========================================
- Hits 4626 4603 -23
Misses 523 523
|
Basic user:
--> returns only y, yhat and the updated uncertainty intervals Advanced user:
--> returns updated uncertainty intervals (conformal prediction: naive or cqr) and previous quantile regression intervals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🔬 Background
The forecast data frames gets a new column for every new uncertainty prediction method which leads to a very large data frame.
Fixes issue #1261
🔮 Key changes
The initial uncertainty intervals are overwritten with the new ones when a new uncertainty prediction method is used.
📋 Review Checklist