Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Calculate major frequency percentage properly #1264

Merged
merged 6 commits into from
Apr 14, 2023

Conversation

noxan
Copy link
Collaborator

@noxan noxan commented Apr 14, 2023

Fix for #1233

@noxan noxan self-assigned this Apr 14, 2023
@github-actions
Copy link

github-actions bot commented Apr 14, 2023

Model Benchmark

Benchmark Metric main current diff
AirPassengers MAE_val 15.2698 15.2698 0.0%
AirPassengers RMSE_val 19.4209 19.4209 0.0%
AirPassengers Loss_val 0.00195 0.00195 0.0%
AirPassengers MAE 9.82902 9.82902 0.0%
AirPassengers RMSE 11.7005 11.7005 0.0%
AirPassengers Loss 0.00056 0.00056 0.0%
AirPassengers time 4.12418 4.06 -1.56%
YosemiteTemps MAE_val 1.71298 1.71298 0.0%
YosemiteTemps RMSE_val 2.2607 2.2607 0.0%
YosemiteTemps Loss_val 0.00095 0.00095 0.0%
YosemiteTemps MAE 1.45187 1.45187 0.0%
YosemiteTemps RMSE 2.16721 2.16721 0.0%
YosemiteTemps Loss 0.00066 0.00066 0.0%
YosemiteTemps time 92.5742 93.12 0.59%
PeytonManning MAE_val 0.58159 0.58159 0.0%
PeytonManning RMSE_val 0.72216 0.72216 0.0%
PeytonManning Loss_val 0.01239 0.01239 0.0%
PeytonManning MAE 0.41671 0.41671 0.0%
PeytonManning RMSE 0.55961 0.55961 0.0%
PeytonManning Loss 0.00612 0.00612 0.0%
PeytonManning time 11.6549 11.73 0.64%
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

Copy link
Collaborator

@LeonieFreisinger LeonieFreisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job in improving readability

"""
dominant_frequencies = [freq for freq in frequencies if freq in filter_list]
dominant_distribution = [distribution[np.where(frequencies == freq)] for freq in dominant_frequencies]
return sum(dominant_distribution) / sum(distribution)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noxan Can we ensure that we never divide by zero? I am not too deep into this function, but thought we should think abou it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would mean the dataset is empty

@noxan noxan merged commit cdedd4e into main Apr 14, 2023
@noxan noxan deleted the 1233-major-frequency-ms-corresponds-to branch April 14, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants