-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[major] speed up nested additive model #1311
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1311 +/- ##
==========================================
+ Coverage 89.84% 89.87% +0.03%
==========================================
Files 38 38
Lines 5149 5126 -23
==========================================
- Hits 4626 4607 -19
+ Misses 523 519 -4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!! Amazing!!
We can single-track the compute_components later.
Model Benchmark
|
🔬 Background
The first implementation includes two forward() passes and hence unnecessary many function calls. --> Objective: Reduce computation time.
🔮 Key changes
📋 Review Checklist
Please make sure to follow our best practices in the Contributing guidelines.