Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Downgrade kaleido version to 0.2.1 to fix installs #1320

Merged
merged 1 commit into from
May 2, 2023

Conversation

noxan
Copy link
Collaborator

@noxan noxan commented May 2, 2023

🔬 Background

@noxan noxan requested a review from leoniewgnr May 2, 2023 01:42
@github-actions
Copy link

github-actions bot commented May 2, 2023

Model Benchmark

Benchmark Metric main current diff
AirPassengers MAE_val 13.0626 13.0626 0.0%
AirPassengers RMSE_val 15.9452 15.9453 0.0%
AirPassengers Loss_val 0.00131 0.00131 0.0%
AirPassengers MAE 9.88156 9.88156 0.0%
AirPassengers RMSE 11.7354 11.7354 0.0%
AirPassengers Loss 0.00052 0.00052 0.0%
AirPassengers time 7.37107 5.83 -20.91% 🎉
PeytonManning MAE_val 0.58159 0.58159 -0.0%
PeytonManning RMSE_val 0.72216 0.72216 0.0%
PeytonManning Loss_val 0.01239 0.01239 -0.0%
PeytonManning MAE 0.41671 0.41671 -0.0%
PeytonManning RMSE 0.55961 0.55961 0.0%
PeytonManning Loss 0.00612 0.00612 0.0%
PeytonManning time 18.505 14.71 -20.51% 🎉
YosemiteTemps MAE_val 1.3442 1.3442 -0.0%
YosemiteTemps RMSE_val 2.00245 2.00245 -0.0%
YosemiteTemps Loss_val 0.00077 0.00077 -0.0%
YosemiteTemps MAE 1.3192 1.3192 0.0%
YosemiteTemps RMSE 2.13518 2.13518 -0.0%
YosemiteTemps Loss 0.00064 0.00064 -0.0%
YosemiteTemps time 87.7165 68.01 -22.47% 🎉
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@codecov-commenter
Copy link

Codecov Report

Merging #1320 (5ea046c) into main (2c37302) will increase coverage by 0.01%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1320      +/-   ##
==========================================
+ Coverage   89.81%   89.83%   +0.01%     
==========================================
  Files          38       38              
  Lines        5104     5104              
==========================================
+ Hits         4584     4585       +1     
+ Misses        520      519       -1     

see 1 file with indirect coverage changes

Copy link
Collaborator

@leoniewgnr leoniewgnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoniewgnr leoniewgnr merged commit ee8b76f into main May 2, 2023
@leoniewgnr leoniewgnr deleted the fix-kaleido branch May 2, 2023 01:50
@aguennoune
Copy link

Thanks to @noxan for the solution
// output:

Updating dependencies
Resolving dependencies... (106.2s)

Package operations: 0 installs, 2 updates, 0 removals

• Updating matplotlib (3.6.0 -> 3.8.0)
• Updating kaleido (0.2.1 /home/conda/feedstock_root/build_artifacts/python-kaleido_1615204619408/work -> 0.2.1.post1): Failed

RuntimeError

Unable to find installation candidates for kaleido (0.2.1.post1)

at ~/.local/lib/python3.7/site-packages/poetry/installation/chooser.py:76 in choose_for
72│
73│ links.append(link)
74│
75│ if not links:
→ 76│ raise RuntimeError(f"Unable to find installation candidates for {package}")
77│
78│ # Get the best link
79│ chosen = max(links, key=lambda link: self._sort_key(package, link))
80│

After downgraded kaleido version to 0.2.1, it fixed the issue

// output:
Updating dependencies
Resolving dependencies... (38.1s)

Package operations: 0 installs, 2 updates, 0 removals

• Updating matplotlib (3.6.0 -> 3.8.0)
• Updating kaleido (0.2.1 /home/conda/feedstock_root/build_artifacts/python-kaleido_1615204619408/work -> 0.2.1)

Writing lock file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants