Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Fix pyright and flake8 warnings #1392

Merged
merged 3 commits into from
Aug 8, 2023
Merged

Conversation

leoniewgnr
Copy link
Collaborator

🔬 Background

Flake8 and pyright warnings in #1390

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Model Benchmark

Benchmark Metric main current diff
YosemiteTemps MAE_val 1.3442 1.3442 0.0%
YosemiteTemps RMSE_val 2.00245 2.00245 0.0%
YosemiteTemps Loss_val 0.00077 0.00077 0.0%
YosemiteTemps MAE 1.3192 1.3192 0.0%
YosemiteTemps RMSE 2.13518 2.13518 0.0%
YosemiteTemps Loss 0.00064 0.00064 0.0%
YosemiteTemps time 73.6353 76.71 4.18% ⚠️
PeytonManning MAE_val 0.58159 0.58159 0.0%
PeytonManning RMSE_val 0.72216 0.72216 0.0%
PeytonManning Loss_val 0.01239 0.01239 0.0%
PeytonManning MAE 0.41671 0.41671 0.0%
PeytonManning RMSE 0.55961 0.55961 0.0%
PeytonManning Loss 0.00612 0.00612 0.0%
PeytonManning time 15.6988 15.7 0.01%
AirPassengers MAE_val 13.0626 13.0626 0.0%
AirPassengers RMSE_val 15.9453 15.9453 0.0%
AirPassengers Loss_val 0.00131 0.00131 0.0%
AirPassengers MAE 9.88156 9.88156 0.0%
AirPassengers RMSE 11.7354 11.7354 0.0%
AirPassengers Loss 0.00052 0.00052 0.0%
AirPassengers time 6.69342 6.64 -0.8%
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #1392 (6fac1ed) into main (bb2ca36) will not change coverage.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##             main    #1392   +/-   ##
=======================================
  Coverage   89.81%   89.81%           
=======================================
  Files          38       38           
  Lines        5058     5058           
=======================================
  Hits         4543     4543           
  Misses        515      515           
Files Changed Coverage Δ
neuralprophet/df_utils.py 94.50% <66.66%> (ø)
neuralprophet/utils_torch.py 90.69% <100.00%> (ø)

@leoniewgnr leoniewgnr changed the title fixed black8 warnings [bug] Fix pyright and flake8 warnings Aug 4, 2023
@leoniewgnr leoniewgnr marked this pull request as ready for review August 4, 2023 19:14
@leoniewgnr leoniewgnr self-assigned this Aug 4, 2023
@leoniewgnr leoniewgnr added the status: needs review PR needs to be reviewed by Reviewer(s) label Aug 4, 2023
@leoniewgnr leoniewgnr requested a review from noxan August 4, 2023 19:16
@leoniewgnr leoniewgnr merged commit b18c8ab into main Aug 8, 2023
13 of 14 checks passed
@leoniewgnr leoniewgnr deleted the fix-pyright-flake8-warnings branch August 8, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review PR needs to be reviewed by Reviewer(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants