Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[major] Upgrade to PyTorch 2 #1404

Merged
merged 3 commits into from
Aug 30, 2023
Merged

[major] Upgrade to PyTorch 2 #1404

merged 3 commits into from
Aug 30, 2023

Conversation

noxan
Copy link
Collaborator

@noxan noxan commented Aug 16, 2023

Another attempt to upgrade to PyTorch 2.0

@github-actions
Copy link

github-actions bot commented Aug 16, 2023

Model Benchmark

Benchmark Metric main current diff
YosemiteTemps MAE_val 1.349 1.34899 -0.0%
YosemiteTemps RMSE_val 2.00817 2.00817 -0.0%
YosemiteTemps Loss_val 0.00078 0.00078 -0.0%
YosemiteTemps MAE 1.32133 1.32133 0.0%
YosemiteTemps RMSE 2.13713 2.13713 -0.0%
YosemiteTemps Loss 0.00064 0.00064 0.0%
YosemiteTemps time 85.3615 62.25 -27.07% 🎉
PeytonManning MAE_val 0.58162 0.58162 0.0%
PeytonManning RMSE_val 0.72218 0.72218 0.0%
PeytonManning Loss_val 0.01239 0.01239 0.0%
PeytonManning MAE 0.41671 0.41671 -0.0%
PeytonManning RMSE 0.55961 0.55961 0.0%
PeytonManning Loss 0.00612 0.00612 -0.0%
PeytonManning time 17.4582 13.43 -23.07% 🎉
AirPassengers MAE_val 13.0627 13.0627 0.0%
AirPassengers RMSE_val 15.9453 15.9453 0.0%
AirPassengers Loss_val 0.00131 0.00131 0.0%
AirPassengers MAE 9.88153 9.88153 0.0%
AirPassengers RMSE 11.7354 11.7354 -0.0%
AirPassengers Loss 0.00052 0.00052 0.0%
AirPassengers time 7.63756 5.61 -26.55% 🎉
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@noxan noxan changed the title [Draft] Upgrade to pytorch 2.0.1 Upgrade to PyTorch 2 Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #1404 (900eda1) into main (d236471) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1404   +/-   ##
=======================================
  Coverage   89.85%   89.85%           
=======================================
  Files          38       38           
  Lines        5068     5068           
=======================================
  Hits         4554     4554           
  Misses        514      514           
Files Changed Coverage Δ
neuralprophet/configure.py 90.18% <100.00%> (ø)

@noxan noxan mentioned this pull request Aug 16, 2023
1 task
Copy link
Collaborator

@leoniewgnr leoniewgnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing, thanks so much Richard!!

@noxan noxan marked this pull request as ready for review August 18, 2023 07:57
@noxan noxan changed the title Upgrade to PyTorch 2 [major] Upgrade to PyTorch 2 Aug 18, 2023
@noxan noxan added status: needs review PR needs to be reviewed by Reviewer(s) status: ready PR is ready to be merged and removed status: needs review PR needs to be reviewed by Reviewer(s) labels Aug 21, 2023
@leoniewgnr
Copy link
Collaborator

@ourownstory what do you think, can we merge that?

@leoniewgnr
Copy link
Collaborator

@ourownstory what do you think, can we merge that?

I'll go ahead and merge this now, I think a lot of users are waiting for it.

2 similar comments
@leoniewgnr
Copy link
Collaborator

@ourownstory what do you think, can we merge that?

I'll go ahead and merge this now, I think a lot of users are waiting for it.

@leoniewgnr
Copy link
Collaborator

@ourownstory what do you think, can we merge that?

I'll go ahead and merge this now, I think a lot of users are waiting for it.

@leoniewgnr leoniewgnr merged commit 40745ab into main Aug 30, 2023
14 checks passed
@leoniewgnr leoniewgnr deleted the pytorch-2 branch August 30, 2023 16:02
@leoniewgnr
Copy link
Collaborator

@noxan this really is amazing, I always had some dependency issues when installing NP with other packages, everything resolved now!

@noxan
Copy link
Collaborator Author

noxan commented Sep 19, 2023

Also wanted to say thank you to @hxyue1 who contributed to this PR kind of behind the scenes and tried several alternative attempts to make this finally work 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready PR is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants