Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Correct holiday test and update version #1431

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Conversation

leoniewgnr
Copy link
Collaborator

@leoniewgnr leoniewgnr commented Sep 26, 2023

🔬 Background

We are comparing holidays by names, but the holidays python package translates 'erster mai' to labor day, which results in two labor days (US and german one), so that the number of holidays are not the same in english and german language (depends on the system language).
This only appears in the newest version of holidays, but I think we should fix that so that we can upgrade holidays

🔮 Key changes

removed line in test

Certainly! Below are the tables for each year, listing the name of the holiday for each date as per the terminal and VS Code data.

Table for 2009

Date English German
2009-01-01 New Year's Day Neujahr
2009-01-19 Martin Luther King Jr. Day Martin Luther King Jr. Day
2009-02-16 Washington's Birthday Washington's Birthday
2009-04-10 Good Friday Karfreitag
2009-04-13 Easter Monday Ostermontag
2009-05-01 Labor Day Erster Mai
2009-05-21 Ascension Day Christi Himmelfahrt
2009-05-25 Memorial Day Memorial Day
2009-06-01 Whit Monday Pfingstmontag
2009-07-03 Independence Day (Observed) Independence Day (Observed)
2009-07-04 Independence Day Independence Day
2009-09-07 Labor Day Labor Day
2009-10-03 German Unity Day Tag der Deutschen Einheit
2009-10-12 Columbus Day Columbus Day
2009-11-11 Veterans Day Veterans Day
2009-11-26 Thanksgiving Thanksgiving
2009-12-25 Christmas Day Erster Weihnachtstag
2009-12-26 Second Day of Christmas Zweiter Weihnachtstag

@leoniewgnr leoniewgnr changed the title Fix holiday test Fix holiday test and update version Sep 26, 2023
@leoniewgnr leoniewgnr marked this pull request as ready for review September 26, 2023 04:50
@leoniewgnr leoniewgnr added the status: needs review PR needs to be reviewed by Reviewer(s) label Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #1431 (dc2a8f5) into main (50d5e41) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1431   +/-   ##
=======================================
  Coverage   89.85%   89.85%           
=======================================
  Files          38       38           
  Lines        5084     5086    +2     
=======================================
+ Hits         4568     4570    +2     
  Misses        516      516           
Files Coverage Δ
neuralprophet/forecaster.py 87.40% <ø> (ø)
neuralprophet/utils.py 79.66% <100.00%> (+0.11%) ⬆️

@github-actions
Copy link

github-actions bot commented Sep 26, 2023

Model Benchmark

Benchmark Metric main current diff
YosemiteTemps MAE_val 1.34899 1.34899 0.0%
YosemiteTemps RMSE_val 2.00817 2.00817 0.0%
YosemiteTemps Loss_val 0.00078 0.00078 0.0%
YosemiteTemps MAE 1.32133 1.32133 0.0%
YosemiteTemps RMSE 2.13713 2.13713 0.0%
YosemiteTemps Loss 0.00064 0.00064 0.0%
YosemiteTemps time 60.5567 66.3 9.48%
PeytonManning MAE_val 0.58162 0.58162 0.0%
PeytonManning RMSE_val 0.72218 0.72218 0.0%
PeytonManning Loss_val 0.01239 0.01239 0.0%
PeytonManning MAE 0.41671 0.41671 0.0%
PeytonManning RMSE 0.55961 0.55961 0.0%
PeytonManning Loss 0.00612 0.00612 0.0%
PeytonManning time 12.7091 13.88 9.21%
AirPassengers MAE_val 13.0627 13.0627 0.0%
AirPassengers RMSE_val 15.9453 15.9453 0.0%
AirPassengers Loss_val 0.00131 0.00131 0.0%
AirPassengers MAE 9.88153 9.88153 0.0%
AirPassengers RMSE 11.7354 11.7354 0.0%
AirPassengers Loss 0.00052 0.00052 0.0%
AirPassengers time 5.36092 5.51 2.78%
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@SimonWittner SimonWittner added status: ready PR is ready to be merged and removed status: ready PR is ready to be merged labels Sep 27, 2023
@leoniewgnr leoniewgnr merged commit 1aa9f37 into main Sep 28, 2023
14 checks passed
@leoniewgnr leoniewgnr deleted the fix-holiday-test branch September 28, 2023 16:14
@ourownstory ourownstory changed the title Fix holiday test and update version [fix] Correct holiday test and update version Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review PR needs to be reviewed by Reviewer(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants