Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] Helperfunction to support equidistant data without datestamps #1432

Merged
merged 5 commits into from
Oct 3, 2023

Conversation

SimonWittner
Copy link
Collaborator

🔬 Background

🔮 Key changes

  • Helperfunction for dummy datestamps and Pytest

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

@SimonWittner SimonWittner changed the title [feature] helperfunction datestamps [feature] Helperfunction to support equidistant data without datestamps Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #1432 (8504096) into main (50d5e41) will increase coverage by 0.01%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 8504096 differs from pull request most recent head 8bca801. Consider uploading reports for the commit 8bca801 to get more accurate results

@@            Coverage Diff             @@
##             main    #1432      +/-   ##
==========================================
+ Coverage   89.85%   89.86%   +0.01%     
==========================================
  Files          38       38              
  Lines        5084     5093       +9     
==========================================
+ Hits         4568     4577       +9     
  Misses        516      516              
Files Coverage Δ
neuralprophet/df_utils.py 94.73% <100.00%> (+0.07%) ⬆️

@SimonWittner SimonWittner added the status: needs review PR needs to be reviewed by Reviewer(s) label Sep 26, 2023
Copy link
Owner

@ourownstory ourownstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!
Please add a mini-example in the docstring.

@SimonWittner SimonWittner merged commit 1b31928 into ourownstory:main Oct 3, 2023
6 of 11 checks passed
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Model Benchmark

Benchmark Metric main current diff
YosemiteTemps MAE_val 1.34899 1.34899 0.0%
YosemiteTemps RMSE_val 2.00817 2.00817 0.0%
YosemiteTemps Loss_val 0.00078 0.00078 0.0%
YosemiteTemps MAE 1.32133 1.32133 0.0%
YosemiteTemps RMSE 2.13713 2.13713 0.0%
YosemiteTemps Loss 0.00064 0.00064 0.0%
YosemiteTemps time 57.3789 59.09 2.98%
PeytonManning MAE_val 0.58162 0.58162 0.0%
PeytonManning RMSE_val 0.72218 0.72218 0.0%
PeytonManning Loss_val 0.01239 0.01239 0.0%
PeytonManning MAE 0.41671 0.41671 0.0%
PeytonManning RMSE 0.55961 0.55961 0.0%
PeytonManning Loss 0.00612 0.00612 0.0%
PeytonManning time 12.9164 12.76 -1.21%
AirPassengers MAE_val 13.0627 13.0627 0.0%
AirPassengers RMSE_val 15.9453 15.9453 0.0%
AirPassengers Loss_val 0.00131 0.00131 0.0%
AirPassengers MAE 9.88153 9.88153 0.0%
AirPassengers RMSE 11.7354 11.7354 0.0%
AirPassengers Loss 0.00052 0.00052 0.0%
AirPassengers time 5.31523 5.32 0.09%
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@ourownstory
Copy link
Owner

Note: needs mention in some tutorial or docs

@ourownstory ourownstory changed the title [feature] Helperfunction to support equidistant data without datestamps [minor] Helperfunction to support equidistant data without datestamps Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review PR needs to be reviewed by Reviewer(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-date data: Support equidistant data without datestamps
2 participants